Closed Bug 1276895 Opened 6 years ago Closed 6 years ago

Remove backward compatible code for Firefox 38ESR from Firefox UI tests script

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Our Firefox UI tests scripts have backward compatible code which was necessary to run our tests for Firefox 38ESR. We should get this all (e.g. external github repo and branches) cleaned up.

It has to wait until https://github.com/mozilla/mozmill-ci/issues/784 has been deployed to production.
Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/1-2/
Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/2-3/
Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

https://reviewboard.mozilla.org/r/61382/#review58302
Attachment #8766511 - Flags: review?(mjzffr) → review+
The last push simply rebased the code based on the bustage fixes which I had to make over on bug 1283396.
Assignee: nobody → hskupin
Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/3-4/
Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/4-5/
Try server build failed because the last rebase was not complete. Looks like git doesn't pull in changes from another branch when commits have been squashed there. So a part of the other patch was missing. I triggered another try build to ensure it works this time.
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d2952ce50f3
[mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/8d2952ce50f3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1284533
You need to log in before you can comment on or make changes to this bug.