1276895 - Remove backward compatible code for Firefox 38ESR from Firefox UI tests script

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Our Firefox UI tests scripts have backward compatible code which was necessary to run our tests for Firefox 38ESR. We should get this all (e.g. external github repo and branches) cleaned up.

It has to wait until https://github.com/mozilla/mozmill-ci/issues/784 has been deployed to production.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review commit: https://reviewboard.mozilla.org/r/61382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61382/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/1-2/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/2-3/

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

https://reviewboard.mozilla.org/r/61382/#review58302

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The last push simply rebased the code based on the bustage fixes which I had to make over on bug 1283396.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/3-4/

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8766511 [details]
Bug 1276895 - [mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61382/diff/4-5/

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Try server build failed because the last rebase was not complete. Looks like git doesn't pull in changes from another branch when commits have been squashed there. So a part of the other patch was missing. I triggered another try build to ensure it works this time.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d2952ce50f3
[mozharness] Remove backward compatible code for Firefox 38ESR from Firefox UI tests. r=maja_zf

Comment 10

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/8d2952ce50f3