1276938 - Optimize string usage in setAttribute when dealing with HTML elements

Status: RESOLVED FIXED

Description

[Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.)]

Created attachment 8758272 [details] [diff] [review]
less_attr_lowercase.diff

We do a virtual call to InternalGetExistingAttrNameFromQName and nsContentUtils::ASCIIToLower is called twice when adding an attribute.

The patch tries to be consistent with the new aNameToUse handling so that it is set to some
value only if there isn't existing attribute.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd4376104618b3320af40503bd366b78063f7811

Comment 1

[Andrea Marchesini [:baku]]

Comment on attachment 8758272 [details] [diff] [review]
less_attr_lowercase.diff

Review of attachment 8758272 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Element.h
@@ +659,5 @@
>                           const nsAString& aLocalName,
>                           ErrorResult& aError);
>    bool HasAttribute(const nsAString& aName) const
>    {
> +    return InternalGetAttrNameFromQName(aName) != nullptr;

maybe !!InternalGetAttrNameFromQName(aName);

Comment 2

[Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.)]

well, I just renamed the method, not changed its usage.

Comment 3

[Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.)]

hmm, tryserver seems to have some unrelated issues atm.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7b7ea5b410e
Optimize string usage in setAttribute when dealing with HTML elements, r=baku

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7b7ea5b410e