Closed Bug 1276977 Opened 4 years ago Closed 4 years ago

Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''java.lang.String org.mozilla.gecko.Tab.getUserRequested()'' on a null object reference at org.mozilla.gecko.BrowserApp.enterEditingMode(BrowserApp.java)

Categories

(Firefox for Android :: General, defect)

Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed
fennec + ---

People

(Reporter: aklotz, Assigned: ahunt)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-abbc8785-4b31-45d4-9e2f-487532160530.
=============================================================
tracking-fennec: --- → ?
Looks like it might be a simple null check. Margaret can we get an assignee?
tracking-fennec: ? → +
Flags: needinfo?(margaret.leibovic)
ahunt, can you take a look?
Flags: needinfo?(margaret.leibovic) → needinfo?(ahunt)
Assignee: nobody → ahunt
Huh, we already do a nullcheck for that call.

However I've noticed the results of the call that crashes are unused, so we can at least completely remove that code. (I wonder if that confuses the compiler/optimiser and we therefore don't get a nullcheck, but that's pure speculation.)
Status: NEW → ASSIGNED
Flags: needinfo?(ahunt)
Apparently this code can crash despite the nullcheck, let's completely
remove it since we don't use the results.

Review commit: https://reviewboard.mozilla.org/r/57386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57386/
Attachment #8759380 - Flags: review?(liuche)
Attachment #8759380 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/7e530b2a462a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.