Closed Bug 1276977 Opened 4 years ago Closed 4 years ago
Crash in java
.lang .Null Pointer Exception: Attempt to invoke virtual method ''java .lang .String org .mozilla .gecko .Tab .get User Requested()'' on a null object reference at org .mozilla .gecko .Browser App .enter Editing Mode(Browser App .java)
This bug was filed from the Socorro interface and is report bp-abbc8785-4b31-45d4-9e2f-487532160530. =============================================================
Looks like it might be a simple null check. Margaret can we get an assignee?
tracking-fennec: ? → +
ahunt, can you take a look?
Flags: needinfo?(margaret.leibovic) → needinfo?(ahunt)
Huh, we already do a nullcheck for that call. However I've noticed the results of the call that crashes are unused, so we can at least completely remove that code. (I wonder if that confuses the compiler/optimiser and we therefore don't get a nullcheck, but that's pure speculation.)
Status: NEW → ASSIGNED
Apparently this code can crash despite the nullcheck, let's completely remove it since we don't use the results. Review commit: https://reviewboard.mozilla.org/r/57386/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57386/
Attachment #8759380 - Flags: review?(liuche)
Comment on attachment 8759380 [details] Bug 1276977 - remove unused variable and call https://reviewboard.mozilla.org/r/57386/#review54182
https://hg.mozilla.org/integration/fx-team/rev/7e530b2a462aeb163112e30c869442e2d6a54eef Bug 1276977 - remove unused variable and call r=liuche
You need to log in before you can comment on or make changes to this bug.