1276977 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''java.lang.String org.mozilla.gecko.Tab.getUserRequested()'' on a null object reference at org.mozilla.gecko.BrowserApp.enterEditingMode(BrowserApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This bug was filed from the Socorro interface and is 
report bp-abbc8785-4b31-45d4-9e2f-487532160530.
=============================================================

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like it might be a simple null check. Margaret can we get an assignee?

Comment 2

[:Margaret Leibovic]

ahunt, can you take a look?

Comment 3

[Andrzej Hunt :ahunt]

Huh, we already do a nullcheck for that call.

However I've noticed the results of the call that crashes are unused, so we can at least completely remove that code. (I wonder if that confuses the compiler/optimiser and we therefore don't get a nullcheck, but that's pure speculation.)

Comment 4

[Andrzej Hunt :ahunt]

Attachment: Bug 1276977 - remove unused variable and call

Apparently this code can crash despite the nullcheck, let's completely
remove it since we don't use the results.

Review commit: https://reviewboard.mozilla.org/r/57386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57386/

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8759380 [details]
Bug 1276977 - remove unused variable and call

https://reviewboard.mozilla.org/r/57386/#review54182

Comment 6

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/7e530b2a462aeb163112e30c869442e2d6a54eef
Bug 1276977 - remove unused variable and call r=liuche

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e530b2a462a