Closed Bug 1277001 Opened 3 years ago Closed 3 years ago

Use BlobPart in the Blob/File webidl interface

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

Attached patch blob.patchSplinter Review
No description provided.
Attachment #8758357 - Flags: review?(bugs)
Comment on attachment 8758357 [details] [diff] [review]
blob.patch

So this is a change to the behavior (DOMString -> USVString)
Please test how other browsers work, if unusual string data is passed.
With that, r+.

https://github.com/w3c/FileAPI/issues/30 is a recent spec change.
Ms2ger, did anyone check what browsers actually do before the spec change was done.
Attachment #8758357 - Flags: review?(bugs)
Attachment #8758357 - Flags: review+
Attachment #8758357 - Flags: feedback?(Ms2ger)
BlobSet::AppendString uses NS_ConvertUTF16toUTF8, which already replaces unpaired surrogates by U+FFFD, so there's no behaviour change in using USVString here.
Attachment #8758357 - Flags: feedback?(Ms2ger)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/045cdefdb941
Use BlobPart in the Blob/File webidl interface, r=smaug
https://hg.mozilla.org/mozilla-central/rev/045cdefdb941
https://hg.mozilla.org/mozilla-central/rev/e08645cf7793
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.