Closed Bug 1277004 Opened 4 years ago Closed 4 years ago

font color from installed theme used inappropriately in the addressbook

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(thunderbird46 wontfix, thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4549+ fixed)

RESOLVED FIXED
Thunderbird 49.0
Tracking Status
thunderbird46 --- wontfix
thunderbird47 --- wontfix
thunderbird48 --- fixed
thunderbird49 --- fixed
thunderbird_esr45 49+ fixed

People

(Reporter: aceman, Assigned: Paenglab)

Details

Attachments

(2 files)

Attached image bad font color pic
The font color from installed theme is used in the Addressbook when displaying an LDAP directory, while no search has been done yet. So the message says you need to search and the message is in theme color, but the background is not from the theme so the colors mismatch. See attachment.
Attached patch Bug1277004.patchSplinter Review
This fixes it.
Attachment #8758388 - Flags: review?(acelists)
Comment on attachment 8758388 [details] [diff] [review]
Bug1277004.patch

Review of attachment 8758388 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.
Attachment #8758388 - Flags: review?(acelists) → review+
http://hg.mozilla.org/comm-central/rev/d4c9beeca8ed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
Comment on attachment 8758388 [details] [diff] [review]
Bug1277004.patch

[Approval Request Comment]
User impact if declined: depending on LW-theme not or hard readable LDAP info text
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8758388 - Flags: approval-comm-esr45?
Attachment #8758388 - Flags: approval-comm-beta?
Attachment #8758388 - Flags: approval-comm-aurora?
Attachment #8758388 - Flags: approval-comm-aurora? → approval-comm-aurora+
Too late for TB 47 beta now.
Attachment #8758388 - Flags: approval-comm-beta?
You need to log in before you can comment on or make changes to this bug.