font color from installed theme used inappropriately in the addressbook

RESOLVED FIXED in Thunderbird 49.0

Status

RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: aceman, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 49.0

Thunderbird Tracking Flags

(thunderbird46 wontfix, thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4549+ fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8758361 [details]
bad font color pic

The font color from installed theme is used in the Addressbook when displaying an LDAP directory, while no search has been done yet. So the message says you need to search and the message is in theme color, but the background is not from the theme so the colors mismatch. See attachment.
(Assignee)

Comment 1

3 years ago
Created attachment 8758388 [details] [diff] [review]
Bug1277004.patch

This fixes it.
Attachment #8758388 - Flags: review?(acelists)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8758388 [details] [diff] [review]
Bug1277004.patch

Review of attachment 8758388 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.
Attachment #8758388 - Flags: review?(acelists) → review+
(Assignee)

Comment 3

3 years ago
http://hg.mozilla.org/comm-central/rev/d4c9beeca8ed
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
(Assignee)

Comment 4

3 years ago
Comment on attachment 8758388 [details] [diff] [review]
Bug1277004.patch

[Approval Request Comment]
User impact if declined: depending on LW-theme not or hard readable LDAP info text
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8758388 - Flags: approval-comm-esr45?
Attachment #8758388 - Flags: approval-comm-beta?
Attachment #8758388 - Flags: approval-comm-aurora?

Updated

3 years ago
Attachment #8758388 - Flags: approval-comm-aurora? → approval-comm-aurora+

Comment 5

3 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/1057658a4ce7
status-thunderbird46: --- → wontfix
status-thunderbird47: --- → affected
status-thunderbird48: --- → fixed
status-thunderbird49: --- → fixed
status-thunderbird_esr45: --- → affected
tracking-thunderbird_esr45: --- → ?

Comment 6

3 years ago
Too late for TB 47 beta now.
status-thunderbird47: affected → wontfix

Updated

3 years ago
Attachment #8758388 - Flags: approval-comm-beta?

Updated

2 years ago
status-thunderbird_esr45: affected → fixed
tracking-thunderbird_esr45: ? → 49+
You need to log in before you can comment on or make changes to this bug.