1277023 - Delete key has no function in alias window

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, enhancement)

Description

[Martin F.]

In the alias list in account preferences, it should be possible to trigger the delete action using the [Delete] key on the keyboard.

Comment 1

[:aceman]

Attachment: patch

Yes, this is doable.
The patch adds Delete for deletion, Insert for "add...".

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8776286 [details] [diff] [review]
patch

Review of attachment 8776286 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/am-identities-list.js
@@ +126,5 @@
>  
> +  gEditButton.setAttribute("disabled", "false");
> +  gDeleteButton.setAttribute("disabled", (gIdentityListBox.itemCount <= 1) ? "true" : "false");
> +  gSetDefaultButton.setAttribute("disabled", (gIdentityListBox.selectedIndex == 0) ? "true" : "false");
> +  // The Add command is always be enabled.

Why all the changes to use setAttribute("disabled") instead of .disabled?

Comment 3

[:aceman]

It seems to me there is no "disabled" property on a <command>, only an attribute.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8776286 [details] [diff] [review]
patch

Review of attachment 8776286 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! r=mkmelin

Comment 5

[:aceman]

https://hg.mozilla.org/comm-central/rev/c482d8a2cd6178a9e5990c07b6c7c09dc63d919d

Comment 6

[Jorg K (CEST = GMT+2)]

English derailed here:
https://hg.mozilla.org/comm-central/rev/c482d8a2cd6178a9e5990c07b6c7c09dc63d919d#l1.52
"The Add command is always be enabled."
Right ;-)

Comment 7

[Jorg K (CEST = GMT+2)]

Fixed that:
https://hg.mozilla.org/comm-central/rev/44003aa9b4de
I needed something to push since the previous push went in with DONTBUILD for no apparent reason.