Unbust merge day gecko_migration.py from VCS refactor

RESOLVED DUPLICATE of bug 1277041

Status

Release Engineering
Mozharness
RESOLVED DUPLICATE of bug 1277041
2 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
gecko_migration.py is currently busted in multiple ways.

Will work on some patches...
(Assignee)

Comment 1

2 years ago
Created attachment 8758403 [details]
MozReview Request: Bug 1277046 - Use "branch" argument instead of "revision"; r?jlund

"default" is a symbolic name. We can't use "revision" with it.

Review commit: https://reviewboard.mozilla.org/r/56638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56638/
Attachment #8758403 - Flags: review?(jlund)
(Assignee)

Comment 2

2 years ago
I thought things were going to be busted more than they are. I thought the shared repos would cause issues because of the ambiguity of the "default" branch. But it looks like we have multiple checkouts and we're resolving revisions from the working directory. So we should be fine.

Comment 3

2 years ago
Comment on attachment 8758403 [details]
MozReview Request: Bug 1277046 - Use "branch" argument instead of "revision"; r?jlund

https://reviewboard.mozilla.org/r/56638/#review53314

will need to deal with shared dir and clean_repos assumes 'revision' key in vcs_config. addressing those in https://reviewboard.mozilla.org/r/56642/diff/1-2/
Attachment #8758403 - Flags: review?(jlund)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1277041
You need to log in before you can comment on or make changes to this bug.