1277046 - Unbust merge day gecko_migration.py from VCS refactor

Status: RESOLVED DUPLICATE of bug 1277041

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Gregory Szorc [:gps]]

gecko_migration.py is currently busted in multiple ways.

Will work on some patches...

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1277046 - Use "branch" argument instead of "revision"; r?jlund

"default" is a symbolic name. We can't use "revision" with it.

Review commit: https://reviewboard.mozilla.org/r/56638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56638/

Comment 2

[Gregory Szorc [:gps]]

I thought things were going to be busted more than they are. I thought the shared repos would cause issues because of the ambiguity of the "default" branch. But it looks like we have multiple checkouts and we're resolving revisions from the working directory. So we should be fine.

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8758403 [details]
MozReview Request: Bug 1277046 - Use "branch" argument instead of "revision"; r?jlund

https://reviewboard.mozilla.org/r/56638/#review53314

will need to deal with shared dir and clean_repos assumes 'revision' key in vcs_config. addressing those in https://reviewboard.mozilla.org/r/56642/diff/1-2/