1277067 - Remove nsIAsyncShutdown.contentChildShutdown

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Description

[Andrew McCreight [:mccr8]]

Once the users of this are removed, then we should remove it so nobody starts using it. We want to avoid it because it slows down the shutdown of content processes in release builds.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

We shouldn't forget to document in the idl and jsm why we're doing this. Otherwise, people will just re-add it.

Comment 2

[Andrew McCreight [:mccr8]]

(In reply to David Rajchenbach-Teller [:Yoric] (please use "needinfo") from comment #1)
> We shouldn't forget to document in the idl and jsm why we're doing this.
> Otherwise, people will just re-add it.

That sounds reasonable. It shouldn't be a long-term risk, because there is work underway to make the other user of content-child-shutdown, telemetry, not use it, whereupon it can be removed entirely.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Remove nsIAsyncShutdown.contentChildShutdown.

try run (with patches for the other blocking bugs):
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbb7fd16bff0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efcca7d36ad4
Remove nsIAsyncShutdown.contentChildShutdown. r=Yoric

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efcca7d36ad4