Closed
Bug 1277103
Opened 8 years ago
Closed 8 years ago
git mozreview doesn't work from git worktrees again with cinnabar master
Categories
(MozReview Graveyard :: Integration: Git, defect)
MozReview Graveyard
Integration: Git
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
When `git mozreview credentials` is executed by git/cinnabar from a worktree, GIT_DIR is set to the directory of the private worktree repository, and GIT_COMMON_DIR is not set, so we don't actually get the right directory, and the credentials command fails with the error saying running git mozreview configure is necessary. So just always rely on git rev-parse. Review commit: https://reviewboard.mozilla.org/r/56750/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56750/
Attachment #8758490 -
Flags: review?(gps)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8758490 [details] MozReview Request: Bug 1277103 - Always use git rev-parse to get git_dir. r?gps https://reviewboard.mozilla.org/r/56750/#review53464
Attachment #8758490 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/88d628552126
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Pushed by mh@glandium.org https://hg.mozilla.org/hgcustom/version-control-tools/rev/88d628552126 Always use git rev-parse to get git_dir. r=gps
You need to log in
before you can comment on or make changes to this bug.
Description
•