Closed Bug 1277124 Opened 3 years ago Closed 3 years ago
Remove outdated definition in the Gecko
58 bytes, text/x-review-board-request
No description provided.
When building a desktop version of Firefox with MOZ_LINKER enabled, the zlib library is necessary for mozglue. The mozglue library is statically linked to programs on desktop builds of Firefox, and the required setup for those things is done in the GeckoProgram template, along with adding the necessary zlib linkage. Not sure how events went through but the current definitions in mozglue/build/moz.build and config/external/zlib/moz.build make it that USE_LIBS += ['mozglue'] currently implies zlib being linked in that case without it being done explicitly in GeckoProgram, so remove that. Review commit: https://reviewboard.mozilla.org/r/56784/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56784/
Attachment #8758512 - Flags: review?(mshal)
Comment on attachment 8758512 [details] MozReview Request: Bug 1277124 - Remove outdated definition in GeckoProgram. r?mshal https://reviewboard.mozilla.org/r/56784/#review53658
Attachment #8758512 - Flags: review?(mshal) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b74c4db83cc Remove outdated definition in GeckoProgram. r=mshal
You need to log in before you can comment on or make changes to this bug.