Closed Bug 1277124 Opened 3 years ago Closed 3 years ago

Remove outdated definition in the GeckoProgram template

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

No description provided.
When building a desktop version of Firefox with MOZ_LINKER enabled, the
zlib library is necessary for mozglue. The mozglue library is statically
linked to programs on desktop builds of Firefox, and the required setup
for those things is done in the GeckoProgram template, along with adding
the necessary zlib linkage.

Not sure how events went through but the current definitions in
mozglue/build/moz.build and config/external/zlib/moz.build make it that
USE_LIBS += ['mozglue'] currently implies zlib being linked in that case
without it being done explicitly in GeckoProgram, so remove that.

Review commit: https://reviewboard.mozilla.org/r/56784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56784/
Attachment #8758512 - Flags: review?(mshal)
Comment on attachment 8758512 [details]
MozReview Request: Bug 1277124 - Remove outdated definition in GeckoProgram. r?mshal

https://reviewboard.mozilla.org/r/56784/#review53658
Attachment #8758512 - Flags: review?(mshal) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b74c4db83cc
Remove outdated definition in GeckoProgram. r=mshal
https://hg.mozilla.org/mozilla-central/rev/2b74c4db83cc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.