1277189 - Upgrade to NDK r11c on builders to avoid x86 miscompile

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Xidorn Quan [:xidorn] UTC+11]

+++ This bug was initially created as a clone of Bug #1165460 +++

It seems crash in bug 1273048 is due to a miscompile from the NDK compiler, and according to glandium from IRC, NDK r11c would bring us a compiler which has the fix of that issue.

Comment 1

[Mike Hommey [:glandium]]

James, do you want to take care of this?

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

BTW, do we have any plan to use Clang rather than GCC for Android build? It seems GCC is deprecated in the NDK since r11 and would no longer get upgrade for anything other than some miscompile and ICE cases.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Xidorn Quan [:xidorn] (PTO June 6 ~ 10) from comment #2)
> BTW, do we have any plan to use Clang rather than GCC for Android build? It
> seems GCC is deprecated in the NDK since r11 and would no longer get upgrade
> for anything other than some miscompile and ICE cases.

Nathan and I have talked about it. He thinks it should be doable. He also updated the NDK last, so maybe he has a script for this?

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #3)
> (In reply to Xidorn Quan [:xidorn] (PTO June 6 ~ 10) from comment #2)
> > BTW, do we have any plan to use Clang rather than GCC for Android build? It
> > seems GCC is deprecated in the NDK since r11 and would no longer get upgrade
> > for anything other than some miscompile and ICE cases.
> 
> Nathan and I have talked about it. He thinks it should be doable. He also
> updated the NDK last, so maybe he has a script for this?

Yeah, I'll whip together a tarball and upgrade.  I'm also working on getting clang support more polished, though it sounds like a lot of the hard parts are being done in glandium's mega-rewrite of the build system. ;)

Comment 5

[Nathan Froyd [:froydnj]]

Oh, the clang-on-android bug is bug 1163171, if anybody wants to follow along.

Comment 6

[Nathan Froyd [:froydnj]]

Attachment: update android to NDK r11c

Here are the tooltool changes.  Apparently we should have moved x86 to r11b,
but didn't; this patch corrects that mistake.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9231cfab7da
update android to NDK r11c; r=snorp

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9231cfab7da