1277227 - Several thumbnail will be briefly replaced with an incorrect favicon/background

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build: 8bb33eb
Device: IPad mini 4

Steps to reproduce:
1. Login to FxA and complete first sync
2. Open About home
3. Background Firefox by pressing the Home button
4. Restore Firefox

Results: Several thumbnail will be briefly  replaced with the one from Wikipedia.

Expected: The correct thumbnail should be displayed.

See the URL for more information: https://www.youtube.com/watch?v=1ctL2Z_Jc6Y&feature=youtu.be

Comment 1

[Aaron Train [:aaronmt]]

I think this is bug 1270765.

Comment 2

[Farhan Patel [:farhan]]

Is this related to bug 1270765?

Comment 3

[Bryan Munar (:bkmunar)]

hm.. I'm honestly not too sure because a) I tried looking into this and kind of failed lol... and b) but I think it might NOT be because the flicker is separate from the Wikipedia tile magic stuff. If you see in the video, some tiles turn into Wikipedia (AND some turn into Yahoo!!) before the spazzy flicker happens.

Maybe a reuse issue with the icons/backgrounds?

Comment 4

[Aaron Train [:aaronmt]]

Please re-test on master with bug 1270765 resolved, let's see if this is resolved too. Re-open if this is still reproducible.

Comment 5

[Simon Basca [:SimonB]]

Tested on master 6cab24f7 on iPad mini 4 and iPad Air 2.
The issue is still reproducible following the above STR. 

Please note that the issue is reproducible only on tablet devices.

Comment 6

[Aaron Train [:aaronmt]]

:sleroux can you take a look at this?

Comment 7

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1949

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8765551 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1949

Hrm, I wish this stuff was better documented. Do the top sites still layout correctly if rotating the device between steps 3 and 4? If so, WFM.

Comment 9

[Stephan Leroux [:sleroux]]

master 435e66383c8d1532878b413ed679eb0d59d4b91a

Comment 10

[Stephan Leroux [:sleroux]]

v5.x f39865b