Active Accessibility: nsIAccessible's accDoAction does not work for Html Check Box Node

VERIFIED FIXED in mozilla1.0

Status

()

Core
Disability Access APIs
P2
normal
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: dsirnapalli, Assigned: Aaron Leventhal)

Tracking

({access, sec508, topembed+})

Trunk
mozilla1.0
x86
Windows NT
access, sec508, topembed+
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

16 years ago
-- I wrote onClick event on checkbox. When we call accDoAction on Html Check 
box node it does check the checkbox but the event is not fired. 
<input type="checkbox" name="sex" onClick="nodeChecked();"> Above 30
i put some alert statements in nodeChecked() function. they dont get fired when 
the click happens through accDoAction.
i attached a simple test case.run the test case from mozilla or mozinspect. be 
sure to insert the following line in prefs.js
user_pref("signed.applets.codebase_principal_support", true);
(Reporter)

Comment 1

16 years ago
Created attachment 71340 [details]
Simple test case to reproduce the bug.
(Assignee)

Updated

16 years ago
Depends on: 127812

Updated

16 years ago
No longer depends on: 127812

Updated

16 years ago
Blocks: 127812
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: access, fcc508, nsbeta1
Priority: -- → P2
Target Milestone: --- → mozilla1.0
(Assignee)

Updated

16 years ago
Blocks: 75785
(Assignee)

Updated

16 years ago
Keywords: topembed

Updated

16 years ago
Keywords: topembed → topembed+

Comment 2

16 years ago
nsbeta1+ per ADT/Embed triage.
Depends on: 57209
Keywords: nsbeta1 → nsbeta1+

Comment 3

16 years ago
Created attachment 72559 [details] [diff] [review]
patch

use Click method instead of SetChecked to do the default action in
AccDoAction function.

Kyle
(Assignee)

Comment 4

16 years ago
Comment on attachment 72559 [details] [diff] [review]
patch

Very good, thank you.
Please remove the old lines, instead of just // commenting them out. 

If you comment lines out, always make sure you also say why they are commented
out. Engineers reading the code in the future may not understand why they have
// in front of them.

Please submit a new patch with the commented lines.

Also, when you attach the patch, be sure to check the checkbox marked "patch"
Attachment #72559 - Attachment is patch: true

Comment 5

16 years ago
Created attachment 72710 [details] [diff] [review]
new patch

this is a new patch which commented lines are removed.
(Assignee)

Comment 6

16 years ago
Comment on attachment 72710 [details] [diff] [review]
new patch

r=aaronl
Attachment #72710 - Flags: review+

Comment 7

16 years ago
Created attachment 72718 [details] [diff] [review]
new patch (v3)

hi, Aaron, I found that there are some potential errors in 
nsHTMLRadioButtonAccessible::AccDoAction and 
nsHTMLButtonAccessible::AccDoAction which does not check the
element pointer carefully. 
So I re-submited the patch.
(Assignee)

Comment 8

16 years ago
Comment on attachment 72718 [details] [diff] [review]
new patch (v3)

Thanks! r=aaronl
Attachment #72718 - Flags: review+
(Assignee)

Comment 9

16 years ago
Comment on attachment 72710 [details] [diff] [review]
new patch

Marking obsolete. Whenever you attach a new patch, you should mark the old one
obsolete with the checkbox in that page.
Attachment #72710 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #72559 - Flags: review+
(Assignee)

Updated

16 years ago
Attachment #72559 - Attachment is obsolete: true
Attachment #72559 - Flags: review+

Comment 10

16 years ago
Yes, I wanted to do that, but the system told me that I haven't
the enough privilege.

Comment 11

16 years ago
Comment on attachment 72718 [details] [diff] [review]
new patch (v3)

sr=sfraser
Attachment #72718 - Flags: superreview+

Comment 12

16 years ago
Comment on attachment 72718 [details] [diff] [review]
new patch (v3)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72718 - Flags: approval+

Comment 13

16 years ago
fixed. need to be checkined.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 14

16 years ago
I believe Aaron already checked this in when he checked in your other bug ( bug
57263 ). 

In the future, leave the bug unresloved until it gets checked in. In other
words, if the fix is not in the tree ( checked in ) then the bug really isn't
fixed. In this case, I'm pretty sure Aaron checked this in, so I won't reopen 
the bug.

(Assignee)

Comment 15

16 years ago
This was in fact checked in.
Sorry for not marking it earlier.
(Reporter)

Updated

16 years ago
QA Contact: doronr → dsirnapalli
(Reporter)

Comment 16

16 years ago
-- Verified the fix on yesterday's trunk build. 
Works fine. Marking the bug as verified.
Status: RESOLVED → VERIFIED

Updated

16 years ago
Component: Browser-General → Accessibility APIs
You need to log in before you can comment on or make changes to this bug.