-- I wrote onClick event on checkbox. When we call accDoAction on Html Check box node it does check the checkbox but the event is not fired. <input type="checkbox" name="sex" onClick="nodeChecked();"> Above 30 i put some alert statements in nodeChecked() function. they dont get fired when the click happens through accDoAction. i attached a simple test case.run the test case from mozilla or mozinspect. be sure to insert the following line in prefs.js user_pref("signed.applets.codebase_principal_support", true);
use Click method instead of SetChecked to do the default action in AccDoAction function. Kyle
Comment on attachment 72559 [details] [diff] [review] patch Very good, thank you. Please remove the old lines, instead of just // commenting them out. If you comment lines out, always make sure you also say why they are commented out. Engineers reading the code in the future may not understand why they have // in front of them. Please submit a new patch with the commented lines. Also, when you attach the patch, be sure to check the checkbox marked "patch"
Attachment #72559 - Attachment is patch: true
this is a new patch which commented lines are removed.
Comment on attachment 72710 [details] [diff] [review] new patch r=aaronl
Attachment #72710 - Flags: review+
hi, Aaron, I found that there are some potential errors in nsHTMLRadioButtonAccessible::AccDoAction and nsHTMLButtonAccessible::AccDoAction which does not check the element pointer carefully. So I re-submited the patch.
Comment on attachment 72718 [details] [diff] [review] new patch (v3) Thanks! r=aaronl
Attachment #72718 - Flags: review+
Comment on attachment 72710 [details] [diff] [review] new patch Marking obsolete. Whenever you attach a new patch, you should mark the old one obsolete with the checkbox in that page.
Attachment #72710 - Attachment is obsolete: true
Yes, I wanted to do that, but the system told me that I haven't the enough privilege.
Comment on attachment 72718 [details] [diff] [review] new patch (v3) sr=sfraser
Attachment #72718 - Flags: superreview+
Comment on attachment 72718 [details] [diff] [review] new patch (v3) a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72718 - Flags: approval+
fixed. need to be checkined.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
I believe Aaron already checked this in when he checked in your other bug ( bug 57263 ). In the future, leave the bug unresloved until it gets checked in. In other words, if the fix is not in the tree ( checked in ) then the bug really isn't fixed. In this case, I'm pretty sure Aaron checked this in, so I won't reopen the bug.
This was in fact checked in. Sorry for not marking it earlier.
-- Verified the fix on yesterday's trunk build. Works fine. Marking the bug as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.