Closed Bug 1277274 Opened 8 years ago Closed 7 years ago

Permanent browser_responsiveui_window_close.js | Test timed out | Found a browser window after previous test timed out

Categories

(DevTools :: Responsive Design Mode, defect, P1)

Unspecified
Linux
defect

Tracking

(firefox48 unaffected, firefox49 affected, firefox50 disabled)

RESOLVED INVALID
Tracking Status
firefox48 --- unaffected
firefox49 --- affected
firefox50 --- disabled

People

(Reporter: RyanVM, Unassigned)

References

Details

(Keywords: intermittent-failure, stale-bug, Whiteboard: [test disabled on Linux debug e10s])

Happens on Linux debug e10s. The patch from bug 1242986 should make it easy to test with Linux64 on Try.

https://treeherder.mozilla.org/logviewer.html#?job_id=187852&repo=ash#L5007

04:34:08     INFO -  476 INFO TEST-START | devtools/client/responsivedesign/test/browser_responsiveui_window_close.js
04:34:08     INFO -  477 INFO Entering test bound
04:34:08     INFO -  ++DOCSHELL 0x7fa78f9e7000 == 9 [pid = 1432] [id = 13]
04:34:08     INFO -  ++DOMWINDOW == 21 (0x7fa78f9ed800) [pid = 1432] [serial = 31] [outer = (nil)]
04:34:08     INFO -  ++DOMWINDOW == 22 (0x7fa78fb27800) [pid = 1432] [serial = 32] [outer = 0x7fa78f9ed800]
04:34:08     INFO -  ++DOCSHELL 0x7fa78feaf800 == 10 [pid = 1432] [id = 14]
04:34:08     INFO -  ++DOMWINDOW == 23 (0x7fa78feb0800) [pid = 1432] [serial = 33] [outer = (nil)]
04:34:08     INFO -  ++DOCSHELL 0x7fa78feb1800 == 11 [pid = 1432] [id = 15]
04:34:08     INFO -  ++DOMWINDOW == 24 (0x7fa79263a000) [pid = 1432] [serial = 34] [outer = (nil)]
04:34:08     INFO -  ++DOMWINDOW == 25 (0x7fa792ec7400) [pid = 1432] [serial = 35] [outer = 0x7fa79263a000]
04:34:08     INFO -  ++DOCSHELL 0x7fa796672800 == 12 [pid = 1432] [id = 16]
04:34:08     INFO -  ++DOMWINDOW == 26 (0x7fa790d70c00) [pid = 1432] [serial = 36] [outer = (nil)]
04:34:08     INFO -  ++DOMWINDOW == 27 (0x7fa79b950400) [pid = 1432] [serial = 37] [outer = 0x7fa790d70c00]
04:34:08     INFO -  [Parent 1432] WARNING: No inner window available!: file /home/worker/workspace/build/src/dom/base/nsGlobalWindow.cpp, line 9699
04:34:09     INFO -  ++DOMWINDOW == 28 (0x7fa773f28800) [pid = 1432] [serial = 38] [outer = 0x7fa78feb0800]
04:34:09     INFO -  ++DOMWINDOW == 29 (0x7fa773f6d800) [pid = 1432] [serial = 39] [outer = 0x7fa79263a000]
04:34:09     INFO -  ++DOMWINDOW == 30 (0x7fa773f71000) [pid = 1432] [serial = 40] [outer = 0x7fa790d70c00]
04:34:09     INFO -  ++DOMWINDOW == 31 (0x7fa78f6f9000) [pid = 1432] [serial = 41] [outer = 0x7fa790d70c00]
04:34:09     INFO -  ++DOMWINDOW == 32 (0x7fa79b95ac00) [pid = 1432] [serial = 42] [outer = 0x7fa790d70c00]
04:34:10     INFO -  478 INFO Waiting for event: 'load' on [object XULElement].
04:34:11     INFO -  --DOCSHELL 0x7f6488f79800 == 6 [pid = 1494] [id = 9]
04:34:11     INFO -  --DOCSHELL 0x7f648917a000 == 5 [pid = 1494] [id = 8]
04:34:11     INFO -  --DOCSHELL 0x7f6486514000 == 4 [pid = 1494] [id = 7]
04:34:11     INFO -  --DOCSHELL 0x7f6485e70800 == 3 [pid = 1494] [id = 5]
04:34:11     INFO -  --DOCSHELL 0x7f6486523800 == 2 [pid = 1494] [id = 6]
04:34:11     INFO -  --DOCSHELL 0x7f6485e6e000 == 1 [pid = 1494] [id = 4]
04:34:11     INFO -  [Child 1494] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || button == ((mContextMenuTrigger == eNormal) ? eRightButton : eLeftButton)', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MouseEvents.h, line 257
04:34:11     INFO -  [Child 1494] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || button == ((mContextMenuTrigger == eNormal) ? eRightButton : eLeftButton)', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MouseEvents.h, line 257
04:34:11     INFO -  [Child 1494] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || button == ((mContextMenuTrigger == eNormal) ? eRightButton : eLeftButton)', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MouseEvents.h, line 257
04:34:11     INFO -  [Child 1494] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || button == ((mContextMenuTrigger == eNormal) ? eRightButton : eLeftButton)', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MouseEvents.h, line 257
04:34:11     INFO -  [Child 1494] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || button == ((mContextMenuTrigger == eNormal) ? eRightButton : eLeftButton)', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MouseEvents.h, line 257
04:34:11     INFO -  [Child 1494] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || button == ((mContextMenuTrigger == eNormal) ? eRightButton : eLeftButton)', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MouseEvents.h, line 257
04:34:14     INFO -  --DOMWINDOW == 18 (0x7f6485f3dc00) [pid = 1494] [serial = 21] [outer = (nil)] [url = http://mochi.test:8888/browser/devtools/client/responsivedesign/test/touch.html]
04:34:14     INFO -  --DOMWINDOW == 17 (0x7f64869ae800) [pid = 1494] [serial = 9] [outer = (nil)] [url = data:text/html;charset=utf-8,mop<div%20style%3D'height%3A5000px'><%2Fdiv>]
04:34:14     INFO -  --DOMWINDOW == 16 (0x7f64863b3400) [pid = 1494] [serial = 7] [outer = (nil)] [url = about:blank]
04:34:14     INFO -  --DOMWINDOW == 15 (0x7f6485eb5c00) [pid = 1494] [serial = 14] [outer = (nil)] [url = data:text/html,%20Custom%20User%20Agent%20test]
04:34:14     INFO -  --DOMWINDOW == 14 (0x7f6485eb2c00) [pid = 1494] [serial = 12] [outer = (nil)] [url = about:blank]
04:34:14     INFO -  --DOMWINDOW == 31 (0x7fa79b842800) [pid = 1432] [serial = 27] [outer = (nil)] [url = chrome://devtools/content/commandline/commandlineoutput.xhtml]
04:34:14     INFO -  --DOMWINDOW == 30 (0x7fa783cd3c00) [pid = 1432] [serial = 29] [outer = (nil)] [url = about:blank]
04:34:14     INFO -  --DOMWINDOW == 29 (0x7fa78367e000) [pid = 1432] [serial = 26] [outer = (nil)] [url = chrome://devtools/content/commandline/commandlinetooltip.xhtml]
04:34:14     INFO -  --DOMWINDOW == 28 (0x7fa78e035400) [pid = 1432] [serial = 30] [outer = (nil)] [url = about:logo]
04:34:17     INFO -  --DOMWINDOW == 13 (0x7f64863b7000) [pid = 1494] [serial = 8] [outer = (nil)] [url = about:blank]
04:34:17     INFO -  --DOMWINDOW == 12 (0x7f6486a88400) [pid = 1494] [serial = 10] [outer = (nil)] [url = about:blank]
04:34:17     INFO -  --DOMWINDOW == 11 (0x7f648912a800) [pid = 1494] [serial = 11] [outer = (nil)] [url = data:text/html;charset=utf-8,mop<div%20style%3D'height%3A5000px'><%2Fdiv>]
04:34:17     INFO -  --DOMWINDOW == 10 (0x7f64863adc00) [pid = 1494] [serial = 13] [outer = (nil)] [url = about:blank]
04:34:17     INFO -  --DOMWINDOW == 9 (0x7f6485f3ec00) [pid = 1494] [serial = 18] [outer = (nil)] [url = data:text/html,%20Custom%20User%20Agent%20test]
04:34:17     INFO -  --DOMWINDOW == 8 (0x7f6489806400) [pid = 1494] [serial = 16] [outer = (nil)] [url = data:text/html,%20Custom%20User%20Agent%20test]
04:34:17     INFO -  --DOMWINDOW == 7 (0x7f648e33a400) [pid = 1494] [serial = 17] [outer = (nil)] [url = data:text/html,%20Custom%20User%20Agent%20test]
04:34:17     INFO -  --DOMWINDOW == 6 (0x7f648679ac00) [pid = 1494] [serial = 15] [outer = (nil)] [url = about:blank]
04:34:17     INFO -  --DOMWINDOW == 5 (0x7f648ef1b400) [pid = 1494] [serial = 22] [outer = (nil)] [url = about:blank]
04:34:17     INFO -  --DOMWINDOW == 4 (0x7f648ef23000) [pid = 1494] [serial = 23] [outer = (nil)] [url = http://mochi.test:8888/browser/devtools/client/responsivedesign/test/touch.html]
04:34:22     INFO -  --DOMWINDOW == 27 (0x7fa78f6f9000) [pid = 1432] [serial = 41] [outer = (nil)] [url = about:blank]
04:34:22     INFO -  --DOMWINDOW == 26 (0x7fa79b950400) [pid = 1432] [serial = 37] [outer = (nil)] [url = about:blank]
04:34:22     INFO -  --DOMWINDOW == 25 (0x7fa792ec7400) [pid = 1432] [serial = 35] [outer = (nil)] [url = about:blank]
04:34:27     INFO -  479 INFO Console message: [JavaScript Error: "1464755667395	Toolkit.GMP	ERROR	GMPInstallManager.simpleCheckAndInstall Could not check for addons: Error: got node name: html, expected: updates (resource://gre/modules/addons/ProductAddonChecker.jsm:153:11) JS Stack trace: parseXML@ProductAddonChecker.jsm:153:11 < promise callback*ProductAddonChecker.getProductAddonList@ProductAddonChecker.jsm:320:12 < GMPInstallManager.prototype.checkForAddons@GMPInstallManager.jsm:107:5 < GMPInstallManager.prototype.simpleCheckAndInstall<@GMPInstallManager.jsm:204:29 < gBrowserInit._delayedStartup/<@browser.js:1330:7 < setTimeout handler*gBrowserInit._delayedStartup@browser.js:1326:5 < EventListener.handleEvent*gBrowserInit.onLoad@browser.js:1023:5 < onload@browser.xul:1:1" {file: "resource://gre/modules/Log.jsm" line: 753}]
04:34:27     INFO -  App_append@resource://gre/modules/Log.jsm:753:9
04:34:27     INFO -  Logger.prototype.log@resource://gre/modules/Log.jsm:389:7
04:34:27     INFO -  LoggerRepository.prototype.getLoggerWithMessagePrefix/proxy.log@resource://gre/modules/Log.jsm:504:44
04:34:27     INFO -  Logger.prototype.error@resource://gre/modules/Log.jsm:397:5
04:34:27     INFO -  GMPInstallManager.prototype.simpleCheckAndInstall<@resource://gre/modules/GMPInstallManager.jsm:285:7
04:34:27     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:320:40
04:34:27     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:940:21
04:34:27     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
04:34:27     INFO -  Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
04:34:27     INFO -  this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
04:34:27     INFO -  this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
04:34:27     INFO -  GMPInstallManager.prototype.checkForAddons/<@resource://gre/modules/GMPInstallManager.jsm:116:7
04:34:27     INFO -  promise callback*GMPInstallManager.prototype.checkForAddons@resource://gre/modules/GMPInstallManager.jsm:107:5
04:34:27     INFO -  GMPInstallManager.prototype.simpleCheckAndInstall<@resource://gre/modules/GMPInstallManager.jsm:204:29
04:34:27     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:319:40
04:34:27     INFO -  TaskImpl@resource://gre/modules/Task.jsm:280:3
04:34:27     INFO -  createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:254:14
04:34:27     INFO -  gBrowserInit._delayedStartup/<@chrome://browser/content/browser.js:1330:7
04:34:27     INFO -  setTimeout handler*gBrowserInit._delayedStartup@chrome://browser/content/browser.js:1326:5
04:34:27     INFO -  EventListener.handleEvent*gBrowserInit.onLoad@chrome://browser/content/browser.js:1023:5
04:34:27     INFO -  onload@chrome://browser/content/browser.xul:1:1
04:34:30     INFO -  --DOMWINDOW == 24 (0x7fa773f71000) [pid = 1432] [serial = 40] [outer = (nil)] [url = about:blank]
04:34:38     INFO -  --DOMWINDOW == 3 (0x7f648679a400) [pid = 1494] [serial = 19] [outer = (nil)] [url = about:blank]
04:34:42     INFO -  --DOMWINDOW == 2 (0x7f648ef0b800) [pid = 1494] [serial = 20] [outer = (nil)] [url = about:blank]
04:34:54     INFO -  TEST-INFO | started process screentopng
04:34:56     INFO -  TEST-INFO | screentopng: exit 0
04:34:56     INFO -  480 INFO checking window state
04:34:56     INFO -  481 INFO TEST-UNEXPECTED-FAIL | devtools/client/responsivedesign/test/browser_responsiveui_window_close.js | Test timed out -
04:34:56     INFO -  MEMORY STAT | vsize 1087MB | residentFast 296MB | heapAllocated 110MB
04:34:56     INFO -  482 INFO TEST-OK | devtools/client/responsivedesign/test/browser_responsiveui_window_close.js | took 46904ms
04:34:56     INFO -  ++DOCSHELL 0x7f6485e56000 == 2 [pid = 1494] [id = 11]
04:34:56     INFO -  ++DOMWINDOW == 3 (0x7f6485e42c00) [pid = 1494] [serial = 26] [outer = (nil)]
04:34:56     INFO -  ++DOMWINDOW == 4 (0x7f6485e48800) [pid = 1494] [serial = 27] [outer = 0x7f6485e42c00]
04:34:56     INFO -  Not taking screenshot here: see the one that was previously logged
04:34:56     INFO -  483 INFO checking window state
04:34:56     INFO -  484 INFO TEST-UNEXPECTED-FAIL | devtools/client/responsivedesign/test/browser_responsiveui_window_close.js | Found a browser window after previous test timed out -
Flags: needinfo?(bkelly)
Runs in around 1.5sec on Linux opt builds. Other platforms don't show any major slowdowns between opt and debug either.
Looks like maybe its stuck waiting for the new window to load:

04:34:10     INFO -  478 INFO Waiting for event: 'load' on [object XULElement].

Ryan, do you have any ideas?  Maybe I did not open the window in the correct way for e10s?  I'm not very familiar with browser mochitest tests.
Flags: needinfo?(bkelly) → needinfo?(jryans)
(In reply to Ben Kelly [:bkelly] from comment #2)
> Looks like maybe its stuck waiting for the new window to load:
> 
> 04:34:10     INFO -  478 INFO Waiting for event: 'load' on [object
> XULElement].
> 
> Ryan, do you have any ideas?  Maybe I did not open the window in the correct
> way for e10s?  I'm not very familiar with browser mochitest tests.

I have not done too much with opening new windows myself either...  From that info in the log, it seems like it's blocked on the `yield once(newWindow.gBrowser, "load", true);` line, since the `once` helper is what prints such messages.

I'm guessing its timing issue where the load event was already fired on this machine configuration before this once listener is bound.  You may not actually need to wait for _content_ load like this, so you could try just removing that line.

If we do need to wait for the event, this test helper seems to describe exactly this case:

https://dxr.mozilla.org/mozilla-central/rev/4d63dde701b47b8661ab7990f197b6b60e543839/browser/base/content/test/general/browser_newwindow_focus.js#10-35

so that may be worth trying as well.
Flags: needinfo?(jryans)
Flags: needinfo?(bkelly)
ni? myself to skip this on Linux debug next time I'm pushing something
Flags: needinfo?(ryanvm)
Not going to bother disabling on Aurora since Linux debug e10s tests only run on Ash anyway at the moment.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1254b1288956
Flags: needinfo?(ryanvm)
Whiteboard: [test disabled on Linux debug e10s]
Keywords: leave-open
this bug is disabled for linux64 e10s/debug, but it still is failing in opt mode as well.

I ran tests by themselves on try (fresh profile/process per test) and this specific bug showed up:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1cecd7bbe7f3a191591b604705d318b5425963f&filter-searchStr=tc%20dt&selectedJob=30130347

possibly this is easy to reproduce/fix give that information.
I have a fix for this, I think. The test is racy as far as I see, and making Promises scheduling to follow the spec makes it perma-fail.
After a year I think its fair to say I'm not actively working on this.
Flags: needinfo?(bkelly)
This test and the code under test has been removed (bug 1305777).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.