1277334 - Autophone - should support --unittests in addition to -u when specifying tests via try

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

We currently only support the following syntax when processing try build comments for unit tests:

-u autophone-s1s2

we should also support the long form of the option --unittests

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1277334-v1.patch

https://treeherder.allizom.org/#/jobs?filter-searchStr=android&exclusion_profile=false&repo=try&author=[e-mail]&filter-tier=1&filter-tier=2&filter-tier=3&fromchange=1f4ddd81a1d65f7dcc74d5992b622ed48a15e9a5&tochange=97bfa49c6bd452a30d83b7f31a77d28a439c6dac

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8759199 [details] [diff] [review]
bug-1277334-v1.patch

Review of attachment 8759199 [details] [diff] [review]:
-----------------------------------------------------------------

overall this patch looks good- just one question that could expand this slightly.

::: autophone.py
@@ +922,4 @@
>                  # Do not allow global selection of tests
>                  # since Autophone can not handle the load.
>                  tests = []
> +                reTests = re.compile('try:.* (?:-u|--unittests) (.*) -t.*')

any chance we should support --unittest as well?

Comment 3

[Bob Clary [:bc] (inactive)]

I don't think so. mach help try shows

  -u TESTS, --unittests TESTS
                        Test suites to run in their entirety.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

ok, all good!

Comment 5

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/0ffcdcb843cce83e3ef196cc362abbc88f662998

Comment 6

[Bob Clary [:bc] (inactive)]

deployed 2016-06-03 14:05