Autophone - should support --unittests in addition to -u when specifying tests via try

RESOLVED FIXED

Status

Testing
Autophone
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We currently only support the following syntax when processing try build comments for unit tests:

-u autophone-s1s2

we should also support the long form of the option --unittests
Comment on attachment 8759199 [details] [diff] [review]
bug-1277334-v1.patch

Review of attachment 8759199 [details] [diff] [review]:
-----------------------------------------------------------------

overall this patch looks good- just one question that could expand this slightly.

::: autophone.py
@@ +922,4 @@
>                  # Do not allow global selection of tests
>                  # since Autophone can not handle the load.
>                  tests = []
> +                reTests = re.compile('try:.* (?:-u|--unittests) (.*) -t.*')

any chance we should support --unittest as well?
Attachment #8759199 - Flags: review?(jmaher) → review+
(Assignee)

Comment 3

2 years ago
I don't think so. mach help try shows

  -u TESTS, --unittests TESTS
                        Test suites to run in their entirety.
ok, all good!
(Assignee)

Comment 6

2 years ago
deployed 2016-06-03 14:05
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.