1277354 - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_cache-control_request.js | xpcshell return code: 0 when not using cache2

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Jorg K (CEST = GMT+2)]

First seen on C-C June 1st, 2016:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=38740

http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1464802135/comm-central_xp_ix_test-xpcshell-bm112-tests1-windows-build16.txt.gz

INFO -  TEST-START | netwerk/test/unit/test_cache-control_request.js
WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_cache-control_request.js | xpcshell return code: 0
INFO -  TEST-INFO took 375ms
INFO -  >>>>>>>
INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
INFO -  (xpcshell/head.js) | test pending (2)
INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
INFO -  running event loop
INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
INFO -  netwerk/test/unit/test_cache-control_request.js | Starting
INFO -  (xpcshell/head.js) | test pending (3)
INFO -  (xpcshell/head.js) | test run_next_test 0 finished (3)
INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" {file: "resource://gre/modules/Webapps.jsm" line: 20}]"
INFO -  TEST-PASS | netwerk/test/unit/test_cache-control_request.js |  - 5 == 5
INFO -  TEST-PASS | netwerk/test/unit/test_cache-control_request.js |  - true == true
INFO -  Error in closure function: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheStorage.exists]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache-control_request.js :: <TOP_LEVEL> :: line 107"  data: no]
INFO -  C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:ChannelListener.prototype.onStopRequest:172
INFO -  C:\slave\test\build\tests\xpcshell\head.js:_do_main:209
INFO -  C:\slave\test\build\tests\xpcshell\head.js:_execute_test:533
INFO -  -e:null:1
INFO -  exiting test

Comment 1

[Honza Bambas (:mayhemer)]

If this fails I presume it's a perma-failure?  What could cause this:

- do_get_profile() doesn't actually create a profile for the xpc test
- the tree is somehow missing bug 1274585 which is a prerequisite to make this test work with exactly this error

This is a platform code test, running daily on m-c+ that, when hard to fix on c-c, can easily be just disabled on c-c.

Comment 2

[aleth [:aleth]]

mkmelin, is TB still not using cache2?

Comment 3

[Magnus Melin [:mkmelin]]

Unfortunately not using cache2 no, bug 1021843.

Comment 4

[aleth [:aleth]]

(In reply to Magnus Melin from comment #3)
> Unfortunately not using cache2 no, bug 1021843.

Then the question is: is this the point where it becomes essential to make the switch?

I mean, we could disable this test, but does that just hide potential failures due to untested code paths?

Comment 5

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #4)
 > I mean, we could disable this test, but does that just hide potential
> failures due to untested code paths?

Existing example for turning off the test:
https://dxr.mozilla.org/mozilla-central/source/netwerk/test/unit/test_bug651100.js#96

Comment 6

[Jorg K (CEST = GMT+2)]

Note Bug 1241622 comment #2 (quote):
(Honza Bambas (:mayhemer))
> Note that soon (this year) we will remove cache v1 code altogether.

Comment 7

[Honza Bambas (:mayhemer)]

Ah!!  yes, the test is using the new cache apis, right.  Didn't realize that...  

this is more a browser specific feature, I don't think when it breaks, TB will suffer from any serious bug.

Comment 8

[aleth [:aleth]]

Attachment: Disable test_cache-control_request when the old cache API is used

OK, let's disable the test for now. But I don't have confidence it won't affect TB e.g. for people using the feed reader feature.

Comment 9

[Honza Bambas (:mayhemer)]

Comment on attachment 8759172 [details] [diff] [review]
Disable test_cache-control_request when the old cache API is used

Review of attachment 8759172 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[aleth [:aleth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98d69e7bb6090115e70bd86234a92c3a313a5d1c
Bug 1277354 - Disable test_cache-control_request when the old cache API is used. r=mayhemer

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98d69e7bb609
Disable test_cache-control_request when the old cache API is used. r=mayhemer

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98d69e7bb609