Closed Bug 1277357 Opened 4 years ago Closed 4 years ago

Removing CPP Consumer calls to nsDocShell::SetUsePrivateBrowsing

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jandreou25, Assigned: jandreou25)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 2 obsolete files)

Removing the calls to nsDocShell::SetUsePrivateBrowsing from CPP consumers, following Bug 1269361
Assignee: nobody → jandreou
Blocks: 1269361
Attached patch Bug1277357.patch (obsolete) — Splinter Review
I included the JS setters that depend on the change to nsDocShell:SetOriginAttributes in this patch.
Attachment #8758880 - Flags: review?(josh)
Comment on attachment 8758880 [details] [diff] [review]
Bug1277357.patch

Review of attachment 8758880 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/TabChild.cpp
@@ +1564,5 @@
> +          // Make sure private browsing was set in docShell
> +          bool isPrivate = false;
> +          nsresult rv = nsDocShell::Cast(docShell)->GetUsePrivateBrowsing(&isPrivate);
> +          NS_ENSURE_SUCCESS_VOID(rv);
> +          MOZ_ASSERT(isPrivate);

Any particular reason we're choosing here to perform this check?
Attachment #8758880 - Flags: review?(josh) → review+
Attached patch Bug1277357.patch (obsolete) — Splinter Review
The check in TabChild.cpp is no longer required.

I changed nsFrameLoader.cpp to handle cases where a frame's PB is not inherited and set by a chrome flag.
Attachment #8758880 - Attachment is obsolete: true
Flags: needinfo?(josh)
Whiteboard: btpp-active
Comment on attachment 8759695 [details] [diff] [review]
Bug1277357.patch

Review of attachment 8759695 [details] [diff] [review]:
-----------------------------------------------------------------

nit: commit message misspells `consumers` and `nsDocShell::SetUsePrivateBrowsing`.
Attachment #8759695 - Flags: review+
Flags: needinfo?(josh)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b60f0bc5586
Remove nsDocShell:SetUsePrivateBrowsing cpp consumers and some JS consumers r=jdm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2b60f0bc5586
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.