Closed Bug 1277373 Opened 8 years ago Closed 8 years ago

Android lint and checktests permafailing with SyntaxError: unexpected EOF while parsing after bug 1240423 landed.

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49+ fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox49 + fixed

People

(Reporter: KWierso, Assigned: alwu)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

MozReview Request: Bug 1277373 - remove the errors in lint and checktests.
58 bytes, text/x-review-board-request
Margaret
: review+
Details
Keywords: intermittent-failure
Summary: Android lint and checktests permafailing after bug 1240423 landed. → Android lint and checktests permafailing with SyntaxError: unexpected EOF while parsing after bug 1240423 landed.
Assignee: nobody → alwu
Comment on attachment 8759063 [details]
MozReview Request: Bug 1277373 - remove the errors in lint and checktests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57158/diff/1-2/
Attachment #8759063 - Attachment description: MozReview Request: Bug 1277373 - remove 'import Android.R'. → MozReview Request: Bug 1277373 - remove the errors in lint and checktests.
Attachment #8759063 - Flags: review?(margaret.leibovic)
Hi, Margaret,
Could you help me review this patch?
It's used to eliminate the errors in lint and checktests caused from bug1240423.
Thanks!
Comment on attachment 8759063 [details]
MozReview Request: Bug 1277373 - remove the errors in lint and checktests.

https://reviewboard.mozilla.org/r/57158/#review54000
Attachment #8759063 - Flags: review?(margaret.leibovic) → review+
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7916d8bb58d7
remove the errors in lint and checktests. r=Margaret
Just an FYI regarding checkstyle:
 * You can run locally with `./mach gradle app:checkstyle`
 * It will run automatically when pushing to reviewboard – be sure to check the output before agreeing to publish the review requests. Note that you must have an up-to-date version of version-control-tools for this to work – run `./mach mercurial-setup` to get it.
Tracking for 49, looks like this is about to land but in case it doesn't....
tracking-firefox49: --- → +
https://hg.mozilla.org/mozilla-central/rev/7916d8bb58d7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: