1277379 - Consider switching HardwareUtils over to being defined in resource files

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via bug 1079874 code comments:
    <!-- Some devices use resources based on configuration (e.g. large, xlarge) that are inconsistent
         with the configuration retrieved by HardwareUtils (e.g. some custom ROMs allow the user to
         choose a phone or tablet version of the UI even though the hardware stays the same). This
         can cause crashes when we branch on the value returned by HardwareUtils.

         In order to work around this, we define the resource size in resources with the expectation that
         we branch on that value, rather than HardwareUtils, so our code is consistent with the used resources. -->

---

The associated code was added in bug 1079874. For simplicity and prevent side effects, I did not change the existing HardwareUtils code but we should consider moving it over if the changes in bug 1079874 work out.

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.