Closed
Bug 1277426
Opened 8 years ago
Closed 8 years ago
IonMonkey:MIPS: muliply arithmetic optimize with mul instruction
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: hwjeastd07, Assigned: hwjeastd07)
Details
Attachments
(1 file, 3 obsolete files)
|
2.90 KB,
patch
|
hev
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36
Steps to reproduce:
1:patch -p1 <0001-replace-mul-replace-mult-and-mflo.patch
1:compile js engine on mips platform,such as loongson3A.
2:run crypto.js benchmark.
Actual results:
Before patch:
Score: Crytpo: 1024
After patch:
Score: Crypto: 1383
|
Assignee | |
Updated•8 years ago
|
Component: Untriaged → JavaScript Engine: JIT
OS: Unspecified → Linux
Product: Firefox → Core
Hardware: Unspecified → Other
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8758984 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8758990 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8758990 -
Flags: review?(r)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8758992 -
Flags: review?(branislav.rankov)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8758990 [details] [diff] [review] 0001-replace-mul-replace-mult-and-mflo.patch Review of attachment 8758990 [details] [diff] [review]: ----------------------------------------------------------------- Thank you. You should generate patch based on mozilla-inbound. ;)
Attachment #8758990 -
Flags: review?(r)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8758992 -
Attachment is obsolete: true
Attachment #8758992 -
Flags: review?(branislav.rankov)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8759473 [details] [diff] [review] 0001-replace-mul-replace-mult-and-mflo.patch Review of attachment 8759473 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8759473 -
Flags: review+
|
|
||
Updated•8 years ago
|
Assignee: nobody → hwjeastd07
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by r@hev.cc: https://hg.mozilla.org/integration/mozilla-inbound/rev/c2a7b4cefc6e IonMonkey: MIPS: Replace mult/mflo by mul in MulI. r=hev
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c2a7b4cefc6e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•