1277464 - Floating text selection: after changing locale, need to restart browser for floating UI's locale to switch

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect, P3)

Description

[:Grisha Kruglov]

Steps to reproduce:
- say your current language is English. Long-press on some text on some page, observe UI in English ("copy", etc).
- switch locale to another language
- long press on some text - options are still in English!

Restarting the browser seems to be the only thing that switches local in that UI.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Grisha clarified in person that this is changing the locale on the Firefox for Android settings UI. Not the Android locale settings.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Text selection actions are constants and therefore the string does not change:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/ActionBarHandler.js#326

Some are dynamic and instead of a static string use a function:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/ActionBarHandler.js#498-499

I assume that if we make all of them functions that this will work as expected.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Could be a "good first bug" but this needs some validation that the approach works.

Comment 4

[Shan[:Shan11812]]

Attachment: language List Screenshot

@sebastian I've modified the labels of all the actions. How do I test it?
Fennece doesn't show languages list and even though System Default is selected, it doesn't reflect in the app (not only in options but entire app)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

1. Can you upload the patch? If it is fairly simple and just replaces the static string with a function then I'm almost okay with landing it and testing language switching in Nightly. We already know that this won't break because some strings are already functions.

2. You can create a multilocale build and test with that. This is a bit more complicated and requires a full back-end build. Ahunt: Can you link the updated, working doc for multilocale builds?

Comment 6

[Shan[:Shan11812]]

Attachment: Bug 1277464 - Fixed Localization in text selection Context Menus;

Review commit: https://reviewboard.mozilla.org/r/99756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99756/

Comment 7

[Andrzej Hunt :ahunt]

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> 2. You can create a multilocale build and test with that. This is a bit more
> complicated and requires a full back-end build. Ahunt: Can you link the
> updated, working doc for multilocale builds?

Here is the guide:
https://wiki.mozilla.org/index.php?title=Mobile/Fennec/Android/Multilocale_Builds

Feel free to ping/needinfo me if anything is unclear, it's a somewhat long guide.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

@Shan: Do you want to try the multilocale builds?

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8820227 [details]
Bug 1277464 - Fixed Localization in text selection Context Menus;

https://reviewboard.mozilla.org/r/99756/#review101270

LGTM.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f07cc73efbf

Comment 11

[Shan[:Shan11812]]

@sebastian I'm downloading the sources, will probably take a while

Comment 12

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

anyone knows why it's not landed yet ?

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f264c2f5af60
Fixed Localization in text selection Context Menus; r=sebastian

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f264c2f5af60

Comment 15

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 54.0a1(2017-02-16), on Motorola Nexus 6 (Android 7.0).