Open Bug 1277483 Opened 4 years ago Updated 2 years ago

Move --enable-strip and --enable-install-strip to moz.configure


(Firefox Build System :: General, defect)

Not set


(Not tracked)


(Reporter: Ms2ger, Unassigned)



(2 files)

No description provided.
Comment on attachment 8759092 [details] [diff] [review]
Move --enable-strip and --enable-install-strip to moz.configure

Review of attachment 8759092 [details] [diff] [review]:

::: moz.configure
@@ +228,5 @@
>  set_config('MOZ_SYSTEM_HUNSPELL', system_hunspell)
> +
> +option('--enable-strip',

These would be better in build/moz.configure/toolchain.configure.
Attachment #8759092 - Flags: review?(mh+mozilla) → review+
sorry had to back this out for problems like
Flags: needinfo?(Ms2ger)
Any idea?
Flags: needinfo?(Ms2ger) → needinfo?(mh+mozilla)
Attached file logcat
Autophone showed failures which resolved themselves when this was backed out.

PROCESS-CRASH | autophone-s1s2 | java.lang.Exception: Error loading gecko libraries at org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibsNative(Native Method)
Pushed by
Move --enable-strip and --enable-install-strip to moz.configure; r=glandium
Ah, the problem is that the implicit default was --enable-install-strip, and the patch changed that. Turn the option() into --disable-install-strip, and that should work.
Flags: needinfo?(mh+mozilla)
Pushed by
Move --enable-strip and --enable-install-strip to moz.configure; r=glandium
sorry had to back this out for build bustage like
Flags: needinfo?(Ms2ger)
So something else I failed to notice is that PKG_SKIP_STRIP has a default of 1 on msvc and when --disable-compile-environment is passed.
Backout by
Backed out changeset 6134b92d1b08
Backed out changeset 34de8590421f
Backed out changeset f3446f35deed for  Windows 8 x64 opt Build bustage on a CLOSED TREE
Assignee: Ms2ger → nobody
Flags: needinfo?(Ms2ger)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.