Closed Bug 1277490 Opened 8 years ago Closed 8 years ago

add flake8 linter support to talos

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jmaher, Assigned: malayaleecoder)

References

Details

Attachments

(1 file)

Right now we run flake8 on every single talos job from the mozharness wrapper script:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/talos.py#355

now there is a new kid in town with cool linting options:
https://groups.google.com/forum/#!msg/mozilla.tools/iMzB0QrarXA/_hDdPWDfAwAJ

We should remove the flake8 references from talos.py and use the new flake8 work in the new linting job.
malayaleecoder, this seems like a great next bug for you to work on!
Flags: needinfo?(malayaleecoder)
Cool, I will take a look at this :)
Assignee: nobody → malayaleecoder
Status: NEW → ASSIGNED
Flags: needinfo?(malayaleecoder)
Attachment #8765788 - Flags: review?(jmaher)
Comment on attachment 8765788 [details] [diff] [review]
Bug1277490_v1.diff

Review of attachment 8765788 [details] [diff] [review]:
-----------------------------------------------------------------

thank you for the great work here!
Attachment #8765788 - Flags: review?(jmaher) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c647af2120d5
add flake8 linter support to talos r=jmaher
https://hg.mozilla.org/mozilla-central/rev/c647af2120d5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: