1277546 - Missing ref-counting methods for |nsNetworkInfoService| on b2g

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

While linking a for b2g, I see missing ref-counting methods (AddRef, et al) for |nsNetworkInfoService|.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1277546: Don't set BUILD_NETWORK_INFO_SERVICE on B2G

Comment 2

[u408661]

Comment on attachment 8759157 [details] [diff] [review]
[01] Bug 1277546: Don't set BUILD_NETWORK_INFO_SERVICE on B2G

Review of attachment 8759157 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! This looks great, but see the original bug - looks like we're going to back the patch out, and we can just re-land with this change rolled in.

Comment 3

[u408661]

Comment on attachment 8759157 [details] [diff] [review]
[01] Bug 1277546: Don't set BUILD_NETWORK_INFO_SERVICE on B2G

Review of attachment 8759157 [details] [diff] [review]:
-----------------------------------------------------------------

OK, looks like the original bug didn't get backed out entirely, just some minor changes were put in, instead. Guess we'll need this patch after all. (It will need fixing up to apply to the new state of things.)

There is one other place we do similar checks, in netwerk/base/moz.build, so the check there might need to be changed, as well (I'm not clear on the difference between CONFIG['OS_TARGET'] and CONFIG['MOZ_WIDGET_TOOLKIT'], and if CONFIG['OS_TARGET'] == 'Linux' holds for b2g).

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Build |nsNetworkInfoService| on b2g

I updated to the latest m-c and changes the patch. |nsNetworkInfoService| is now build on b2g as well.

Comment 5

[u408661]

Comment on attachment 8760204 [details] [diff] [review]
[01] Build |nsNetworkInfoService| on b2g

Review of attachment 8760204 [details] [diff] [review]:
-----------------------------------------------------------------

This patch also has a ton of unrelated whitespace changes in nsNetModule.cpp, please don't land those. r=nwgh with those changes reverted.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Build |nsNetworkInfoService| on b2g (v2)

Changes since v1:

  - removed whitespace fixes from patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1c93849181d
Build |nsNetworkInfoService| on b2g, r=nwgh

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c1c93849181d

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1c93849181d