127761 - Potential Focus problem when switching application

Status: NEW

(Core :: XUL, defect)

Description

[Jean-Francois Ducarroz]

In nsWindow.cpp, while processing a WM_KILLFOCUS, we set isMozWindowTakingFocus 
to false if the new window that get the focus is own by Mozilla. The problem is 
that since we support drop shadow windows (see bug 118368), we have 2 classes 
of windows in Mozilla but we test only for one of them. That sound wrong to me 
and could probably be the cause of some wierd focus problem.

Comment 1

[Jean-Francois Ducarroz]

proposed fix:

       case WM_KILLFOCUS:
-        char className[19];
-        ::GetClassName((HWND)wParam, className, 19);
-        if(strcmp(className, WindowClass()))
+        char className[29];
+        ::GetClassName((HWND)wParam, className, 29);
+        if(strcmp(className, WindowClass()) && strcmp(className, 
WindowPopupClass()))
           isMozWindowTakingFocus = PR_FALSE;
         if(gJustGotDeactivate) {

Comment 2

[saari (gone)]

Yeah, we need to add any types that we may have added to this check.

Comment 3

[Brendan Eich [:brendan]]

Use sizeof className, not the repeated hardwired 29.  Giving this to bryner,
bounce to trudelle if I did wrong.  I seriously doubt hyatt should get this.

/be

Comment 4

[:deanis74]

+        if(strcmp(className, WindowClass()) && strcmp(className, 
WindowPopupClass()))

Shouldn't that be || instead of &&?

Comment 5

[Jean-Francois Ducarroz]

Right, should be OR (||) and not AND (&&)

Comment 6

[:deanis74]

No, I was wrong.  It should be &&.  Expanded version of what you'd originally
written:

if (strcmp(className, WindowClass()) <> 0 && strcmp(className,
WindowPopupClass()) <> 0)
           isMozWindowTakingFocus = PR_FALSE;

Sorry, strcmps mess me up sometime.  Using || would always evaluate to true.