1277628 - gdb pretty printers don't handle GCPtr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Tromey :tromey]

I've been getting exceptions like this when debugging:

04b4db890 <XPC_WN_OnlyIWrite_AddPropertyStub(JSContext*, JS::Handle<JSObject*>, JS::Handle<jsid>, JS::Handle<JS::Value>)>, obj=Traceback (most recent call last):
  File "/home/tromey/firefox-git/gecko/js/src/gdb/mozilla/prettyprinters.py", line 341, in to_string
    summary = self.summary()
  File "/home/tromey/firefox-git/gecko/js/src/gdb/mozilla/JSObject.py", line 35, in summary
    group = deref(self.value['group_'])
  File "/home/tromey/firefox-git/gecko/js/src/gdb/mozilla/Root.py", line 88, in deref
    raise NotImplementedError
NotImplementedError


I found these are caused by Root.py:deref not handling GCPtr.
I'll attach a patch in a bit.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1277628 - handle js::GCPtr in gdb pretty-printers;

This avoids an error when trying to deref a GCPtr; and also adds the tag
to the NotImplementedError to make it simpler to fix similar bugs in the
future.

Review commit: https://reviewboard.mozilla.org/r/57250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57250/

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8759269 [details]
Bug 1277628 - handle js::GCPtr in gdb pretty-printers;

https://reviewboard.mozilla.org/r/57250/#review54096

Comment 3

[Tom Tromey :tromey]

Try doesn't run the tests for this yet, so no try run.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f729fa97d3a7
handle js::GCPtr in gdb pretty-printers. r=sfink

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f729fa97d3a7