All users were logged out of Bugzilla on October 13th, 2018

desktop_l10n.py should clone gecko by revision for release repacks

RESOLVED FIXED

Status

P1
major
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

unspecified

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

Hit this in 45.2.0 ESR, when we started 2 release processes in parallel and the old one bumped the version on default, what caused "make wget_en_US" fail, because it was trying to download 42.0.0esrpre version.
Supported by passing --revision to desktop_l10n.py fwiw.
doesn't look too hard to fix
Assignee: nobody → rail
Created attachment 8759294 [details]
Bug 1277640 - desktop_l10n.py should clone gecko by revision  a=release DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/57292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57292/
Attachment #8759294 - Flags: review?(bugspam.Callek)
(In reply to Justin Wood (:Callek) from comment #1)
> Supported by passing --revision to desktop_l10n.py fwiw.

we pass the revision via properties (cannot use --revision, which requires a reconfig), but the revision is hardcoded to "default" in the configs.
https://reviewboard.mozilla.org/r/57292/#review54122

https://dxr.mozilla.org/mozilla-central/search?q=path%3Asingle_locale+default&redirect=false

Has a whole bunch of config files you may need/want to change this on, while your change at least protects release... there is also the matter of ensuring that setting %(revision)s works for the CI-based ones (on try) properly.

https://wiki.mozilla.org/ReleaseEngineering/TryServer#Desktop_l10n_jobs
TBH, I less worried about other types ATM. Release l10n repacks first, then we can look at other types.
Comment on attachment 8759294 [details]
Bug 1277640 - desktop_l10n.py should clone gecko by revision  a=release DONTBUILD

https://reviewboard.mozilla.org/r/57292/#review54144

My desire for the try run was primarily so we can ensure this is actually supported, and doesn't break with this and future l10n work on this script.

That said, if it does work I'm ok r+'ing it. Also the --revision passing could be done via `--revision WithProperties(..)` anyway and not need a new reconfig for each release aiui. But in the end, if this works its already written and ok. (I was just hoping to avoid extra complexity in this already complex and weird-assumption-ridden script)
Attachment #8759294 - Flags: review?(bugspam.Callek) → review+
(In reply to Rail Aliiev [:rail] from comment #6)
> TBH, I less worried about other types ATM. Release l10n repacks first, then
> we can look at other types.

Please file a new bug for followup cases though.
I'll land this next week.
Summary: desktop_l10n.py should clone gecko by revision → desktop_l10n.py should clone gecko by revision for release repacks
looks like it requires https://hg.mozilla.org/mozilla-central/rev/e879961960ee, which added revision to runtime config vars.
(In reply to Justin Wood (:Callek) from comment #8)
> (In reply to Rail Aliiev [:rail] from comment #6)
> > TBH, I less worried about other types ATM. Release l10n repacks first, then
> > we can look at other types.
> 
> Please file a new bug for followup cases though.

This is bug 1250626

Comment 12

2 years ago
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e0c246f9a60
desktop_l10n.py should clone gecko by revision r=Callek a=release DONTBUILD
Comment on attachment 8759294 [details]
Bug 1277640 - desktop_l10n.py should clone gecko by revision  a=release DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e0c246f9a60
Attachment #8759294 - Flags: checked-in+

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5e0c246f9a60
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.