Closed Bug 1277641 Opened 4 years ago Closed 4 years ago

[mozlint] Add a --no-filter argument to bypass filtering when experimenting

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

Often a developer may just want to see the lint results of a directory or file, without landing it or anything. But to do this, they need to modify the include/exclude directives in the linter config, such that that path is included.

This is kind of annoying, especially if checking many different paths across the tree. There should be a --no-filter option that bypasses the include/exclude filtering. This will make testing things out locally a lot easier.
This makes it easier to lint a path that otherwise wouldn't have been linted due to the include/exclude
directives. Now, you can pass in -n/--no-filter instead of needing to modify the linter configuration file.

Review commit: https://reviewboard.mozilla.org/r/57276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57276/
Attachment #8759287 - Flags: review?(smacleod)
Comment on attachment 8759287 [details]
Bug 1277641 - [mozlint] Add --no-filter option to make experimenting locally easier,

https://reviewboard.mozilla.org/r/57276/#review55962
Attachment #8759287 - Flags: review?(smacleod) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/259c39227fd6
[mozlint] Add --no-filter option to make experimenting locally easier, r=smacleod
https://hg.mozilla.org/mozilla-central/rev/259c39227fd6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: General → Lint
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.