Closed Bug 1277647 Opened 7 years ago Closed 7 years ago

return the correct type from ANativeWindow_setBuffersGeometry

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

return the correct type from ANativeWindow_setBuffersGeometry
1.36 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
This function returns a boolean, so let's return that, rather than
relying on pointer-to-boolean coercion.
Blocks: 1163171
Comment on attachment 8759296 [details] [diff] [review]
return the correct type from ANativeWindow_setBuffersGeometry

Review of attachment 8759296 [details] [diff] [review]:
-----------------------------------------------------------------

whoops!
Attachment #8759296 - Flags: review?(snorp) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0139b57d0cc
return the correct type from ANativeWindow_setBuffersGeometry; r=snorp
https://hg.mozilla.org/mozilla-central/rev/b0139b57d0cc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.