1277648 - run debug fennec builds alongside opt in taskcluster

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Jordan Lund (:jlund)]

rather than trying to add everything for fennec debug at once, let's break it up and start getting things landed. first up, this bug.

Comment 1

[Jordan Lund (:jlund)]

Attachment: Bug 1277648 - run debug fennec builds alongside opt in taskcluster,

this starts running debug fennec builds along opt on central and try.
note: I added tier 2 and other properties to the opt fennec builds because it
seemed like they were implicitly:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=taskcluster&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false&selectedJob=3999887

Review commit: https://reviewboard.mozilla.org/r/57504/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57504/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://reviewboard.mozilla.org/r/57504/#review54264

::: testing/taskcluster/tasks/branches/mozilla-central/job_flags.yml:21
(Diff revision 1)
>        - Android
>      types:
>        opt:
>          task: tasks/builds/android_api_15.yml
> +      debug:
> +        task: tasks/builds/android_api_15_debug.yml

Why is this not just in base_job_flags.yml?

::: testing/taskcluster/tasks/builds/android_api_15_debug.yml:5
(Diff revision 1)
>  $inherits:
>    from: 'tasks/builds/mobile_base.yml'
>    variables:
>      build_name: 'android'
> -    build_type: 'opt'
> +    build_type: 'dbg'

I believe "dbg" just got changed to "debug" for all of the other task types.

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8759500 [details]
Bug 1277648 - run debug fennec builds alongside opt in taskcluster,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57504/diff/1-2/

Comment 4

[Jordan Lund (:jlund)]

https://reviewboard.mozilla.org/r/57504/#review54264

> Why is this not just in base_job_flags.yml?

do you mean base_jobs.yml? I was keeping where we build android debug to the same place as opt for the moment while I iterate. once things look good, I was going to move debug _and_ the current opt builds to base_jobs.yml and add the flag under `all` for base_jobs_flags.yml.

> I believe "dbg" just got changed to "debug" for all of the other task types.

I guess I based it off linux/osx: https://dxr.mozilla.org/mozilla-central/search?q=path%3Ataskcluster%2Ftasks%2Fbuild+dbg+build_type&redirect=true

but I should have been looking at: https://dxr.mozilla.org/mozilla-central/search?q=path%3Ataskcluster%2Ftasks%2Fbuild+debug+build_type&redirect=true

Comment 5

[Jordan Lund (:jlund)]

(In reply to Jordan Lund (:jlund) from comment #3)
> Comment on attachment 8759500 [details]
> Bug 1277648 - run debug fennec builds alongside opt in taskcluster,
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/57504/diff/1-2/

heh, I think my histedit and rebase confused mozreview.. I really need to figure this out. anyway, I believe the only change should be: build_type: 'debug'

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8759500 [details]
Bug 1277648 - run debug fennec builds alongside opt in taskcluster,

https://reviewboard.mozilla.org/r/57504/#review54460

Comment 7

[Jordan Lund (:jlund)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e057b5daf5814d41680d6309a7bcca9545380051
Bug 1277648 - run debug fennec builds alongside opt in taskcluster, r=dustin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16dfedac79db
Followup bustage fix for Bug 1277648

Comment 9

[Justin Wood (:Callek)]

(In reply to Jordan Lund (:jlund) from comment #7)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> e057b5daf5814d41680d6309a7bcca9545380051
> Bug 1277648 - run debug fennec builds alongside opt in taskcluster, r=dustin

I took the liberty of landing a followup fix to unbust m-c by next merge and try.

(a failing job was: https://tools.taskcluster.net/task-inspector/#cazEvlUESEyG8gX-j_BUAg/0 )

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e057b5daf581
https://hg.mozilla.org/mozilla-central/rev/16dfedac79db