1277668 - NewTabSearchProvider observing unknown topic showing up on console when adding search engines and in test

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Mike Kaply [:mkaply]]

If you have the new tab page up and add a search engine on another tab (for instance from developer.mozilla.org), you get this warning on the console:

NewTabSearchProvider observing unknown topic

You also get it a lot running the search tests, which can leads you to think something is wrong.

Either the new tab should not show this error, or it should ignore the topics in question:

engine-added
engine-loaded
engine-changed
engine-removed

Comment 1

[Florian Quèze [:florian]]

Ursula, is this something you are going to fix? It's causing noise in search tests and thus making them harder to debug.

Comment 2

[Ursula Sarracini (:ursula)]

Sure I can grab this

Comment 3

[Ursula Sarracini (:ursula)]

Attachment: Bug 1277668 - NewTabSearchProvider observing unknown topic showing up on console when adding search engines and in test

Review commit: https://reviewboard.mozilla.org/r/61286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61286/

Comment 4

[Ursula Sarracini (:ursula)]

Comment on attachment 8766342 [details]
Bug 1277668 - NewTabSearchProvider observing unknown topic showing up on console when adding search engines and in test

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61286/diff/1-2/

Comment 5

[Olivier Yiptong [:oyiptong]]

Comment on attachment 8766342 [details]
Bug 1277668 - NewTabSearchProvider observing unknown topic showing up on console when adding search engines and in test

https://reviewboard.mozilla.org/r/61286/#review58414

::: browser/components/newtab/NewTabSearchProvider.jsm:27
(Diff revision 2)
>  
>  function SearchProvider() {
>    EventEmitter.decorate(this);
>  }
>  
>  SearchProvider.prototype = {

this is an r+ pending a successful try-server build.

I suggest `try: -b do -p win32,linux64,macosx64 -u xpcshell,mochitests -t none`

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa8d3ba44f9
NewTabSearchProvider observing unknown topic showing up on console when adding search engines and in test r=oyiptong

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/5fa8d3ba44f9