1277672 - Lint Marionette Driver

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

Nice clean code make the world a better place.

Comment 1

[David Burns :automatedtester]

Attachment: Bug 1277672: Add Marionette Client to included directories for linting.

Review commit: https://reviewboard.mozilla.org/r/57320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57320/

Comment 2

[David Burns :automatedtester]

Attachment: Bug 1277672: Lint Marionette Driver python files

Clean code makes everyone happier...

Review commit: https://reviewboard.mozilla.org/r/57322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57322/

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8759330 [details]
Bug 1277672: Add Marionette Client to included directories for linting.

https://reviewboard.mozilla.org/r/57320/#review54136

Comment 4

[Andrew Halberstadt [:ahal]]

https://reviewboard.mozilla.org/r/57320/#review54140

::: tools/lint/flake8.lint:113
(Diff revision 1)
>      'name': "flake8",
>      'description': "Python linter",
>      'include': [
>          'python/mozlint',
>          'tools/lint',
> +        'testing/marionette/client'

Actually, the commit message says you're adding driver, but this is client. Which one is wrong?

Comment 5

[Andrew Halberstadt [:ahal]]

https://reviewboard.mozilla.org/r/57320/#review54140

> Actually, the commit message says you're adding driver, but this is client. Which one is wrong?

Sigh, I still had a testing/marionette/driver folder locally, but it just has .rej files in it, thus the confusion.. I guess it would still be nice to say client in the commit message though.

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8759331 [details]
Bug 1277672: Lint Marionette Driver python files

https://reviewboard.mozilla.org/r/57322/#review54146

Comment 7

[David Burns :automatedtester]

Attachment: Bug 1277672: Flake8 config for Marionette Driver

Review commit: https://reviewboard.mozilla.org/r/57368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57368/

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8759364 [details]
Bug 1277672: Flake8 config for Marionette Driver

https://reviewboard.mozilla.org/r/57368/#review54154

Comment 9

[David Burns :automatedtester]

Comment on attachment 8759330 [details]
Bug 1277672: Add Marionette Client to included directories for linting.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57320/diff/1-2/

Comment 10

[David Burns :automatedtester]

Comment on attachment 8759331 [details]
Bug 1277672: Lint Marionette Driver python files

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57322/diff/1-2/

Comment 11

[David Burns :automatedtester]

Comment on attachment 8759364 [details]
Bug 1277672: Flake8 config for Marionette Driver

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57368/diff/1-2/

Comment 12

[David Burns :automatedtester]

https://reviewboard.mozilla.org/r/57320/#review54140

> Sigh, I still had a testing/marionette/driver folder locally, but it just has .rej files in it, thus the confusion.. I guess it would still be nice to say client in the commit message though.

Fixed

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27d3e50446a8
Add Marionette Client to included directories for linting. r=ahal
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4bcc6aba08
Lint Marionette Driver python files r=maja_zf
https://hg.mozilla.org/integration/mozilla-inbound/rev/f19d56c111d9
Flake8 config for Marionette Driver r=maja_zf

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/27d3e50446a8
https://hg.mozilla.org/mozilla-central/rev/ac4bcc6aba08
https://hg.mozilla.org/mozilla-central/rev/f19d56c111d9