Closed Bug 1277672 Opened 9 years ago Closed 9 years ago

Lint Marionette Driver

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: automatedtester, Assigned: automatedtester)

References

Details

Attachments

(3 files)

Nice clean code make the world a better place.
Comment on attachment 8759330 [details] Bug 1277672: Add Marionette Client to included directories for linting. https://reviewboard.mozilla.org/r/57320/#review54136
Attachment #8759330 - Flags: review?(ahalberstadt) → review+
https://reviewboard.mozilla.org/r/57320/#review54140 ::: tools/lint/flake8.lint:113 (Diff revision 1) > 'name': "flake8", > 'description': "Python linter", > 'include': [ > 'python/mozlint', > 'tools/lint', > + 'testing/marionette/client' Actually, the commit message says you're adding driver, but this is client. Which one is wrong?
https://reviewboard.mozilla.org/r/57320/#review54140 > Actually, the commit message says you're adding driver, but this is client. Which one is wrong? Sigh, I still had a testing/marionette/driver folder locally, but it just has .rej files in it, thus the confusion.. I guess it would still be nice to say client in the commit message though.
Comment on attachment 8759330 [details] Bug 1277672: Add Marionette Client to included directories for linting. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57320/diff/1-2/
Attachment #8759330 - Attachment description: Bug 1277672: Add Marionette Driver to included directories for linting. → Bug 1277672: Add Marionette Client to included directories for linting.
Comment on attachment 8759331 [details] Bug 1277672: Lint Marionette Driver python files Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57322/diff/1-2/
Comment on attachment 8759364 [details] Bug 1277672: Flake8 config for Marionette Driver Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57368/diff/1-2/
https://reviewboard.mozilla.org/r/57320/#review54140 > Sigh, I still had a testing/marionette/driver folder locally, but it just has .rej files in it, thus the confusion.. I guess it would still be nice to say client in the commit message though. Fixed
Blocks: 1277787
Pushed by dburns@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/27d3e50446a8 Add Marionette Client to included directories for linting. r=ahal https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4bcc6aba08 Lint Marionette Driver python files r=maja_zf https://hg.mozilla.org/integration/mozilla-inbound/rev/f19d56c111d9 Flake8 config for Marionette Driver r=maja_zf
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: