Closed Bug 1277673 Opened 3 years ago Closed 3 years ago

Decouple the ActorActorFront and ActorRegistryFront from the ActorActor and ActorRegistryActor respectively

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.3 - Jun 6
Tracking Status
firefox49 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=23b2371e217b
Assignee: nobody → nfitzgerald
Blocks: 1263289
Status: NEW → ASSIGNED
Whiteboard: [devtools-html]
Flags: qe-verify-
Whiteboard: [devtools-html] → [devtools-html] [triage]
Fix eslint errors that used to be silenced when code resided in the old
location.
Attachment #8759357 - Flags: review?(ejpbruel)
Attachment #8759328 - Attachment is obsolete: true
Attachment #8759328 - Flags: review?(ejpbruel)
Blocks: 1277706
No longer blocks: 1263289
Blocks: 1263289
Comment on attachment 8759357 [details] [diff] [review]
Decouple the ActorActorFront and ActorRegistryFront from the ActorActor and ActorRegistryActor respectively

Review of attachment 8759357 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/actor-registry.js
@@ -28,5 @@
>    },
>  
>    unregister: method(function () {
>      unregisterActor(this.options);
> -  }, {

Please emove the method() call.
Attachment #8759357 - Flags: review?(ejpbruel) → review+
Iteration: --- → 49.3 - Jun 6
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/c28f29acfc2a
Decouple the ActorActorFront and ActorRegistryFront from the ActorActor and ActorRegistryActor respectively; r=ejpbruel
https://hg.mozilla.org/mozilla-central/rev/c28f29acfc2a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Whiteboard: [devtools-html]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.