Closed
Bug 1277674
Opened 8 years ago
Closed 8 years ago
Various browser_dbg_addon tests are going to permafail when Gecko 49 merges to Beta
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: RyanVM, Assigned: jryans)
Details
Attachments
(2 files)
Ryan, it looks like you're the most recent person to touch these tests. Can you please take a look? https://treeherder.mozilla.org/logviewer.html#?job_id=21778673&repo=try#L1752 TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js | Add-on code should be the first group - Got chrome://browser_dbg_addon5, expected browser_dbg_addon5@tests.mozilla.org TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules.js | Add-on code should be the first group - Got chrome://browser_dbg_addon4, expected browser_dbg_addon4@tests.mozilla.org etc...
Flags: needinfo?(jryans)
Assignee | ||
Comment 1•8 years ago
|
||
Okay, I'll take a look.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Flags: needinfo?(jryans)
Assignee | ||
Comment 2•8 years ago
|
||
It was being implicitly loaded into modules by a single arg Cu.import elsewhere in the code base, but only if JSON Viewer is enabled (Dev. Ed and Nightly channels). I plan to address the Cu.import issue more thoroughly over in bug 1193390. Review commit: https://reviewboard.mozilla.org/r/57652/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57652/
Attachment #8759778 -
Flags: review?(ttromey)
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60a9db8cf7a1
Comment 4•8 years ago
|
||
Comment on attachment 8759778 [details] Bug 1277674 - Explicitly require Services in source actor. https://reviewboard.mozilla.org/r/57652/#review54484 Thank you. Looks great.
Attachment #8759778 -
Flags: review?(ttromey) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/4900b0a4b698 Explicitly require Services in source actor. r=tromey
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4900b0a4b698
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•