Closed Bug 1277674 Opened 3 years ago Closed 3 years ago
_dbg _addon tests are going to permafail when Gecko 49 merges to Beta
Ryan, it looks like you're the most recent person to touch these tests. Can you please take a look? https://treeherder.mozilla.org/logviewer.html#?job_id=21778673&repo=try#L1752 TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js | Add-on code should be the first group - Got chrome://browser_dbg_addon5, expected firstname.lastname@example.org TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules.js | Add-on code should be the first group - Got chrome://browser_dbg_addon4, expected email@example.com etc...
Okay, I'll take a look.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
It was being implicitly loaded into modules by a single arg Cu.import elsewhere in the code base, but only if JSON Viewer is enabled (Dev. Ed and Nightly channels). I plan to address the Cu.import issue more thoroughly over in bug 1193390. Review commit: https://reviewboard.mozilla.org/r/57652/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57652/
Attachment #8759778 - Flags: review?(ttromey)
Comment on attachment 8759778 [details] Bug 1277674 - Explicitly require Services in source actor. https://reviewboard.mozilla.org/r/57652/#review54484 Thank you. Looks great.
Attachment #8759778 - Flags: review?(ttromey) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/4900b0a4b698 Explicitly require Services in source actor. r=tromey
You need to log in before you can comment on or make changes to this bug.