Closed
Bug 1277703
Opened 8 years ago
Closed 8 years ago
Mark ComputeContainingBlockRectangle as "const"
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
nsHTMLReflowState::ComputeContainingBlockRectangle is not currently marked as 'const', but it can/should be (since it doesn't modify any member data -- it does its work and produces its output in its return value). Hence, filing this bug.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57400/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57400/
Attachment #8759392 -
Flags: review?(mats)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8759392 [details] Bug 1277703: Mark nsHTMLReflowState::ComputeContainingBlockRectangle as 'const'. https://reviewboard.mozilla.org/r/57400/#review54190
Attachment #8759392 -
Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/952636b63ad7 Mark nsHTMLReflowState::ComputeContainingBlockRectangle as 'const'. r=mats
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/952636b63ad7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•