Closed Bug 1277705 Opened 4 years ago Closed 4 years ago

Remove more Chromium IPC code

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: billm, Assigned: billm)

References

Details

(Whiteboard: btpp-active)

Attachments

(10 files)

2.75 KB, patch
dvander
: review+
Details | Diff | Splinter Review
46.72 KB, patch
dvander
: review+
Details | Diff | Splinter Review
34.19 KB, patch
dvander
: review+
Details | Diff | Splinter Review
3.94 KB, patch
dvander
: review+
Details | Diff | Splinter Review
6.43 KB, patch
dvander
: review+
Details | Diff | Splinter Review
11.83 KB, patch
dvander
: review+
Details | Diff | Splinter Review
7.57 KB, patch
dvander
: review+
Details | Diff | Splinter Review
3.41 KB, patch
dvander
: review+
Details | Diff | Splinter Review
5.25 KB, patch
dvander
: review+
Details | Diff | Splinter Review
4.15 KB, patch
dvander
: review+
Details | Diff | Splinter Review
Lots of process-related stuff can be eliminated.
No one actually listens to these notifications.
Attachment #8759406 - Flags: review?(dvander)
The purpose of all this code is to call OnWaitableEventSignaled at the right time. But all the implementations of these methods are no-ops.
Attachment #8759407 - Flags: review?(dvander)
We only send messages on a channel, so this interface is pointless.
Attachment #8759409 - Flags: review?(dvander)
No one uses this info.
Attachment #8759410 - Flags: review?(dvander)
These are unused now that the notification service is gone.
Attachment #8759411 - Flags: review?(dvander)
Only one of these is ever used.
Attachment #8759413 - Flags: review?(dvander)
More unused stuff here.
Attachment #8759414 - Flags: review?(dvander)
Attachment #8759404 - Flags: review?(dvander) → review+
Attachment #8759406 - Flags: review?(dvander) → review+
Attachment #8759407 - Flags: review?(dvander) → review+
Comment on attachment 8759408 [details] [diff] [review]
remove child process host iterator

Review of attachment 8759408 [details] [diff] [review]:
-----------------------------------------------------------------

I was wondering what this was for.
Attachment #8759408 - Flags: review?(dvander) → review+
Attachment #8759409 - Flags: review?(dvander) → review+
Attachment #8759410 - Flags: review?(dvander) → review+
Attachment #8759411 - Flags: review?(dvander) → review+
Attachment #8759412 - Flags: review?(dvander) → review+
Attachment #8759413 - Flags: review?(dvander) → review+
Attachment #8759414 - Flags: review?(dvander) → review+
Whiteboard: btpp-active
Depends on: 1282559
You need to log in before you can comment on or make changes to this bug.