Closed
Bug 1277742
Opened 5 years ago
Closed 5 years ago
error: 'ChunkSize' was not declared in this scope on aarch64 target
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
1.19 KB,
patch
|
ehoogeveen
:
review+
|
Details | Diff | Splinter Review |
When using GCC 5.3.1 (on Ubuntu 16.04) for aarch64 target, the following build error occurs. 0:12.14B /hg/mozilla-central/js/src/jsapi-tests/testGCAllocator.cpp: In member function 'void* cls_testGCAllocator::mapMemory(size_t)': 0:12.14B /hg/mozilla-central/js/src/jsapi-tests/testGCAllocator.cpp:350:28: error: 'ChunkSize' was not declared in this scope 0:12.14B const uintptr_t step = ChunkSize; 0:12.14B ^ This is regression by the following landing. changeset: 299704:dfaafbaaa291 user: Zheng Xu <zheng.xu@linaro.org> date: Tue May 31 03:22:00 2016 +0200 summary: Bug 1143022 - Manually mmap on arm64 to ensure high 17 bits are clear. r=ehoogeveen
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #8759486 -
Flags: review?(emanuel.hoogeveen)
Comment 2•5 years ago
|
||
Comment on attachment 8759486 [details] [diff] [review] Use correct namespace for ChunkSize on aarch64 Review of attachment 8759486 [details] [diff] [review]: ----------------------------------------------------------------- Ah, surprised this whole test isn't in the GC namespace. Thanks for the patch!
Attachment #8759486 -
Flags: review?(emanuel.hoogeveen) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/58137ecd12ed Use correct namespace for ChunkSize on aarch64. r=ehoogeveen
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/58137ecd12ed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•