Closed Bug 1277752 Opened 3 years ago Closed 3 years ago

Fix two minor netwerk/ issues

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1221162, CID 1345607)

Attachments

(2 files)

Coverity found two issues in netwerk/ that I have patches for.
The AppendElement() call is fallible, so its result must be null-checked.
Attachment #8759506 - Flags: review?(valentin.gosu)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Attachment #8759506 - Flags: review?(valentin.gosu) → review+
Comment on attachment 8759507 [details] [diff] [review]
(part 2) - Check the return value of PR_Seek64() in nsTemporaryFileInputStream::ReadSegments()

Review of attachment 8759507 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8759507 - Flags: review?(valentin.gosu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/79163ae0b445b0a7eba61cb65bd2c8f35fcf6694
Bug 1277752 (part 1) - Add a missing null check in Dashboard::GetDNSCacheEntries(). r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e54065dbe41dc0192f5d1710ad1ba5855f573545
Bug 1277752 (part 2) - Check the return value of PR_Seek64() in nsTemporaryFileInputStream::ReadSegments(). r=valentin.
https://hg.mozilla.org/mozilla-central/rev/79163ae0b445
https://hg.mozilla.org/mozilla-central/rev/e54065dbe41d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.