Closed
Bug 12778
Opened 25 years ago
Closed 25 years ago
MLK: webshell/src/nsDocLoader.cpp
Categories
(Core Graveyard :: Embedding: APIs, defect, P3)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bruce, Assigned: rpotts)
Details
Today's version of webshell/src/nsDocLoader.cpp, line 1202 does a: char* buffer = nsCRT::strdup("?"); and then passes that into uri->GetSpec(&buffer) which should be be strdup()'ing some data. That will overwrite the previous '?' buffer. In addition, in the case of !uri, the PR_LOG() will still run as rv is still true from the GetURI() call on the aLoadInitiator->mDocumentChannel. cc'ing warren and rpotts as they were last in here.
Updated•25 years ago
|
Assignee: nisheeth → rpotts
Comment 1•25 years ago
|
||
Rick should probably look at this.
Reporter | ||
Comment 2•25 years ago
|
||
beard checked in a fix for most of this it appears. Rick might still want to take a look, so I'm not flagging it resolved or anything.
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•25 years ago
|
||
beard's changes look fine... The PR_LOG message for Firing OnEndDocumentLoad(...) will no longer be called if the URL is not available... But this is not a big deal.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 4•25 years ago
|
||
code-level fix, marking VERIFIED per comments
Updated•5 years ago
|
Product: Core → Core Graveyard
Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•