12778 - MLK: webshell/src/nsDocLoader.cpp

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[Bruce Mitchener]

Today's version of webshell/src/nsDocLoader.cpp, line 1202 does a: char* buffer
= nsCRT::strdup("?"); and then passes that into uri->GetSpec(&buffer) which
should be be strdup()'ing some data.  That will overwrite the previous '?'
buffer.  In addition, in the case of !uri, the PR_LOG() will still run as rv is
still true from the GetURI() call on the aLoadInitiator->mDocumentChannel.

cc'ing warren and rpotts as they were last in here.

Comment 1

[Warren Harris]

Rick should probably look at this.

Comment 2

[Bruce Mitchener]

beard checked in a fix for most of this it appears.  Rick might still want to
take a look, so I'm not flagging it resolved or anything.

Comment 3

[rpotts (gone)]

beard's changes look fine...

The PR_LOG message for Firing OnEndDocumentLoad(...) will no longer be called if
the URL is not available...  But this is not a big deal.

Comment 4

[Claudius Gayle]

code-level fix, marking VERIFIED per comments

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/796ccf94ec7b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12778: re-arranged the steps in closeTabTest and closePrivateTabTest (https://github.com/mozilla-mobile/fenix/pull/13810)