Closed Bug 12778 Opened 20 years ago Closed 20 years ago

MLK: webshell/src/nsDocLoader.cpp

Categories

(Core Graveyard :: Embedding: APIs, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bruce, Assigned: rpotts)

Details

Today's version of webshell/src/nsDocLoader.cpp, line 1202 does a: char* buffer
= nsCRT::strdup("?"); and then passes that into uri->GetSpec(&buffer) which
should be be strdup()'ing some data.  That will overwrite the previous '?'
buffer.  In addition, in the case of !uri, the PR_LOG() will still run as rv is
still true from the GetURI() call on the aLoadInitiator->mDocumentChannel.

cc'ing warren and rpotts as they were last in here.
Assignee: nisheeth → rpotts
Rick should probably look at this.
beard checked in a fix for most of this it appears.  Rick might still want to
take a look, so I'm not flagging it resolved or anything.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
beard's changes look fine...

The PR_LOG message for Firing OnEndDocumentLoad(...) will no longer be called if
the URL is not available...  But this is not a big deal.
Status: RESOLVED → VERIFIED
code-level fix, marking VERIFIED per comments
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.