TB45.1.1 Advanced search pane shows "correspondents" column

RESOLVED FIXED in Thunderbird 49.0

Status

Thunderbird
Search
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: nancy.lobaugh, Assigned: Jorg K (GMT+2))

Tracking

45 Branch
Thunderbird 49.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird46 wontfix, thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4548+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

TB45.1.1. mail.threadpane.use_correspondents is set to false.




Actual results:

The Advanced Search (Ctrl-Shift-F) results pane shows "correspondents" instead of "from", the old default...  so I have to deselect and reselect columns manually for each search..

Have also tried with add-ons disabled, with the same behaviour.




Expected results:

I expected that by setting the mail.threadpane.use_correspondents to false, this preference would carry over to searches as well. Can't find anything obvious in config to change.

n.b.. also posted in mozzilla support
(Reporter)

Updated

a year ago
OS: Unspecified → Windows 7
Hardware: Unspecified → x86_64
(Assignee)

Comment 1

a year ago
Damn, we missed a case and the "Correspondents" still show up even if disabled. Thanks for reporting.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 2

a year ago
thanks for getting to it quickly.. will look forward to the patch
(Assignee)

Comment 3

a year ago
Created attachment 8759863 [details] [diff] [review]
Fix (v1).

Same as:
https://dxr.mozilla.org/comm-central/source/mailnews/db/gloda/modules/dbview.js#125
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #8759863 - Flags: review?(acelists)
(Assignee)

Comment 4

a year ago
(In reply to nancy.lobaugh from comment #2)
> thanks for getting to it quickly.. will look forward to the patch
If you like the service, make a donation ;-)
https://donate.mozilla.org/en-US/thunderbird/about/
(Assignee)

Updated

a year ago
status-thunderbird46: --- → wontfix
status-thunderbird47: --- → affected
status-thunderbird48: --- → affected
status-thunderbird49: --- → affected
status-thunderbird_esr45: --- → affected
tracking-thunderbird_esr45: --- → ?

Comment 5

a year ago
Comment on attachment 8759863 [details] [diff] [review]
Fix (v1).

Review of attachment 8759863 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, works for me.
Attachment #8759863 - Flags: review?(acelists) → review+
(Assignee)

Comment 6

a year ago
https://hg.mozilla.org/comm-central/rev/d1ef2c748662

Another act in the drama of the correspondents column ;-(
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-thunderbird49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
(Assignee)

Comment 7

a year ago
Comment on attachment 8759863 [details] [diff] [review]
Fix (v1).

[Approval Request Comment]
Regression caused by (bug #): one of the correspondent column bugs.
User impact if declined: Correspondent column still showing in advanced search.
Testing completed (on c-c, etc.): Manual.
Risk to taking this patch (and alternatives if risky):
Very low risk since it's the same code we already use in gloda search.

Kent, maybe slip this into TB 45.2?
Flags: needinfo?(rkent)
Attachment #8759863 - Flags: approval-comm-esr45?
Attachment #8759863 - Flags: approval-comm-beta?
Attachment #8759863 - Flags: approval-comm-aurora+
(Assignee)

Comment 8

a year ago
Aurora (TB 48):
https://hg.mozilla.org/releases/comm-aurora/rev/a580b291487a
status-thunderbird48: affected → fixed
(Assignee)

Updated

a year ago
Duplicate of this bug: 1278073
"Kent, maybe slip this into TB 45.2?"

Although I agree this is low risk, at the same time the user impact is pretty low as well. Pushing bugs fast to uplift has its costs, and I don't see that the impact of this bug justifies the effort.

Can't we just follow our process (that would mean a fast uplift of this would be to 45.3, not 45.2, with an intervening beta)? Not everything has to be an exception.
Flags: needinfo?(rkent)
(Assignee)

Comment 11

a year ago
Comment on attachment 8759863 [details] [diff] [review]
Fix (v1).

Too late for TB 47 beta now.
Attachment #8759863 - Flags: approval-comm-beta?
(Assignee)

Updated

a year ago
status-thunderbird47: affected → wontfix
Duplicate of this bug: 1283810

Updated

9 months ago
Attachment #8759863 - Flags: approval-comm-esr45? → approval-comm-esr45+

Comment 13

9 months ago
https://hg.mozilla.org/releases/comm-esr45/rev/d273d978917a6ebfae3d632c2a7976505cba01cb
status-thunderbird_esr45: affected → fixed
tracking-thunderbird_esr45: ? → +

Updated

9 months ago
tracking-thunderbird_esr45: + → 48+

Comment 14

9 months ago
Following upgrade to TB 45.3.0, I see that the Correspondents column of the Advanced Search (Ctrl-Shift-F) results pane has been replaced by default with the From column.  But the Recipient column still fails to appear until I manually select it each time I bring up the Advanced Search pane.  Wasn't the intent of the fix to this bug to allow BOTH the From and Recipient columns to appear instead of the Correspondents column?  I do need to see them both for my use of Advanced Search and would prefer to not have to add the Recipient column every time I bring up Advanced Search.
(Assignee)

Comment 15

9 months ago
We restored the original behaviour of TB 38 which only showed the From column.

Comment 16

9 months ago
Isn't it reasonable to expect that the columns a user selects for the Advanced Search pane should remain in place as do the column selections for folders?  Would that have to be a new feature request?

By the way, I've just looked at the beta release for TB 49.0 and see that the Correspondents column still appears there in the Advanced Search pane even with mailnews.ui.upgrade.correspondents set to false.  Is this fix from TB 45.3.0 to get at least the From column back in that pane getting lost in TB 49.0?
(Assignee)

Comment 17

9 months ago
(In reply to Vince at UpperBear from comment #16)
> Isn't it reasonable to expect that the columns a user selects for the
> Advanced Search pane should remain in place as do the column selections for
> folders?  Would that have to be a new feature request?
Yes.

> By the way, I've just looked at the beta release for TB 49.0 and see that
> the Correspondents column still appears there in the Advanced Search pane
> even with mailnews.ui.upgrade.correspondents set to false.  Is this fix from
> TB 45.3.0 to get at least the From column back in that pane getting lost in
> TB 49.0?
The option in TB 45.3 and 49 is called mail.threadpane.use_correspondents. Refer to:
https://support.mozilla.org/en-US/kb/new-thunderbird-45#w_message-list-and-message-header

Comment 18

9 months ago
(In reply to Jorg K (GMT+2, PTO during summer) from comment #17)
> > By the way, I've just looked at the beta release for TB 49.0 and see that
> > the Correspondents column still appears there in the Advanced Search pane
> > even with mailnews.ui.upgrade.correspondents set to false.  Is this fix from
> > TB 45.3.0 to get at least the From column back in that pane getting lost in
> > TB 49.0?
> The option in TB 45.3 and 49 is called mail.threadpane.use_correspondents.
> Refer to:
> https://support.mozilla.org/en-US/kb/new-thunderbird-45#w_message-list-and-
> message-header

I see that the default setting for mail.threadpane.use_correspondents in TB 45.3.0 is "false", but in TB 49.0 beta the default setting is "true".  Why is the Correspondents column coming back by default in TB 49.0?
(Assignee)

Comment 19

9 months ago
(In reply to Vince at UpperBear from comment #18)
> I see that the default setting for mail.threadpane.use_correspondents in TB
> 45.3.0 is "false", but in TB 49.0 beta the default setting is "true".  Why
> is the Correspondents column coming back by default in TB 49.0?
The correspondents are switched of by default in TB 45.x. They will be back in later versions unless you switch them off.
You need to log in before you can comment on or make changes to this bug.