Closed
Bug 1277890
Opened 8 years ago
Closed 8 years ago
do less work with refcounting atoms when using mutation observers
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
(Whiteboard: btpp-active)
Attachments
(3 files)
3.09 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
1.19 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
3.22 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
We have a lot of unnecessary refcounting going on.
Assignee | ||
Comment 1•8 years ago
|
||
This change is a quality-of-life API improvement, and there are a number of other places where it can be used besides this bug.
Attachment #8759719 -
Flags: review?(erahm)
Assignee | ||
Comment 2•8 years ago
|
||
We can pass the atom reference we have into the filter list, there's no need for the filter list to retain a separate reference of the atom.
Attachment #8759720 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•8 years ago
|
||
Once we have references to all the atoms for the filters list, we can pass all those references in, rather than having to copy the array and thus the references.
Attachment #8759721 -
Flags: review?(amarchesini)
Updated•8 years ago
|
Whiteboard: btpp-active
Updated•8 years ago
|
Attachment #8759720 -
Flags: review?(amarchesini) → review+
Updated•8 years ago
|
Attachment #8759721 -
Flags: review?(amarchesini) → review+
Updated•8 years ago
|
Attachment #8759719 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/24cb98ca61ea part 0 - add "append already_AddRefed element" API to nsCOMArray; r=erahm https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f9ed4d6984 part 1 - avoid unnecessary refcounting when building the filters list; r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/93800cba65b2 part 2 - avoid unnecessary refcounting when setting the filters list; r=baku
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/24cb98ca61ea https://hg.mozilla.org/mozilla-central/rev/f7f9ed4d6984 https://hg.mozilla.org/mozilla-central/rev/93800cba65b2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•