Closed Bug 1277900 Opened 8 years ago Closed 7 years ago

Not able to connect to Twitter after logging in

Categories

(Firefox Graveyard :: SocialAPI, defect)

47 Branch
x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: pdol, Unassigned)

References

Details

(Whiteboard: [platform-rel-Twitter])

Attachments

(1 file)

I'm on 47.0b9, OSX

Steps to reproduce:
1) Log into Twitter website
2) Click share button
3) Add Twitter service
4) View error message

Expected result: Able to view share dialog and share to Twitter

Actual result: Error message presented, "Firefox is unable to connect with Twitter right now"
Feel free to change components if this is a Twitter (provider) issue.
Shane, I'm guessing this would be in your wheelhouse?
Flags: needinfo?(mixedpuppy)
Strange.  I'm able to repro on 47, but not on 46 or 48.  Off the top of my head, the only recent change (difference between 47/48) is in bug 1253604, but that shouldn't be affecting this in anyway.  It would be the error handler.  Not clear why and I'm currently OoO for a while.
Flags: needinfo?(mixedpuppy)
(In reply to Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] from comment #3)
> Strange.  I'm able to repro on 47, but not on 46 or 48.  Off the top of my
> head, the only recent change (difference between 47/48) is in bug 1253604,
> but that shouldn't be affecting this in anyway.  It would be the error
> handler.  Not clear why and I'm currently OoO for a while.

Thanks.  Is there anyone else that can take a look while you're out?
Flags: needinfo?(mixedpuppy)
Maybe Mark or Felipe, but it's been a while since they've looked at this as well.
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(markh)
Flags: needinfo?(felipc)
Keywords: qawanted
(In reply to Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] from comment #3)
> Strange.  I'm able to repro on 47, but not on 46 or 48.  Off the top of my
> head, the only recent change (difference between 47/48) is in bug 1253604,
> but that shouldn't be affecting this in anyway.  It would be the error
> handler.  Not clear why and I'm currently OoO for a while.

I can reproduce this on Firefox 46.0.1. (Mac Yosemite)
sigh.  I was trying to look into this further, and it just started working.  I can no longer repro on 47 using a new profile.  I was able to reproduce 100% till just now.
I am using 46 on windows 10. It was working for a while but all of a sudden I get the same error.
Could this be something on Twitter's end?
(In reply to Peter Dolanjski [:pdol] from comment #9)
> Could this be something on Twitter's end?

It's likely an error on Twitter's end, maybe a wrong url for a css file, etc., that would trigger the possibly over zealous error handler used for social frames.  Maybe it's a change in the pages/scripts that a cache hasn't updated entirely.
It seems to be working fine for me now on 47. Can anyone else repro? It could be on Twitter's end. They could have a CDN misconfigured or some load balancer issue which would explain the intermittent action, and we wouldn't know.
I just updated to 47 and can still reproduce this consistently. "Firefox is unable to connect with Twitter right now"
WFM currently.

(In reply to Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] from comment #10)
> that would trigger the possibly over zealous error handler used for
> social frames.  Maybe it's a change in the pages/scripts that a cache hasn't
> updated entirely.

Yeah, that sounds most likely - IIRC, a single file failing is enough to trigger that, even if it is an inconsequential css or js file (but obviously we can't detect how important the failure is)

(In reply to Jonathan Abrams from comment #12)
> I just updated to 47 and can still reproduce this consistently. "Firefox is
> unable to connect with Twitter right now"

It would be great if you could open the "Browser Toolbox" and switch to the Network tab and try again - if Shane's hunch is correct, you will probably see one of the requests made for the share panel failing in some way (probably 404, or 50x)
Flags: needinfo?(markh)
(In reply to Mark Hammond [:markh] from comment #13)
> WFM currently.
> 
> (In reply to Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] from comment
> #10)
> > that would trigger the possibly over zealous error handler used for
> > social frames.  Maybe it's a change in the pages/scripts that a cache hasn't
> > updated entirely.
> 
> Yeah, that sounds most likely - IIRC, a single file failing is enough to
> trigger that, even if it is an inconsequential css or js file (but obviously
> we can't detect how important the failure is)
> 
> (In reply to Jonathan Abrams from comment #12)
> > I just updated to 47 and can still reproduce this consistently. "Firefox is
> > unable to connect with Twitter right now"
> 
> It would be great if you could open the "Browser Toolbox" and switch to the
> Network tab and try again - if Shane's hunch is correct, you will probably
> see one of the requests made for the share panel failing in some way
> (probably 404, or 50x)

Sorry, nothing showing in the network tab when I click on the paper airplane icon to see "Firefox is unable to connect with Twitter right now".

I also tried clearing my browser cache, which did not change things.
(In reply to Jonathan Abrams from comment #14)
> > It would be great if you could open the "Browser Toolbox" and switch to the
> > Network tab and try again - if Shane's hunch is correct, you will probably
> > see one of the requests made for the share panel failing in some way
> > (probably 404, or 50x)
> 
> Sorry, nothing showing in the network tab when I click on the paper airplane
> icon to see "Firefox is unable to connect with Twitter right now".

Is it possible you are just looking at the "Network" tab for the Web Toolbox rather than the browser toolbox (https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox)?  ie, you are looking for a toolbox that opens in its own window detached from the browser window. I see around 14 twitter requests opening the share pane.
(In reply to Mark Hammond [:markh] from comment #15)
> (In reply to Jonathan Abrams from comment #14)
> > > It would be great if you could open the "Browser Toolbox" and switch to the
> > > Network tab and try again - if Shane's hunch is correct, you will probably
> > > see one of the requests made for the share panel failing in some way
> > > (probably 404, or 50x)
> > 
> > Sorry, nothing showing in the network tab when I click on the paper airplane
> > icon to see "Firefox is unable to connect with Twitter right now".
> 
> Is it possible you are just looking at the "Network" tab for the Web Toolbox
> rather than the browser toolbox
> (https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox)?  ie, you
> are looking for a toolbox that opens in its own window detached from the
> browser window. I see around 14 twitter requests opening the share pane.

Ah, OK, using the "browser toolbar", I see a GET request to https://twitter.com/intent/tweet?url=https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox&text=Browser Toolbox - Firefox Developer Tools | MDN but there is no response or status code showing.
OS: Mac OS X → All
I have the same issue on Fx 47 even with the safe mode (so not related to add-ons).   Interestingly the issue doesn't occur when I start Fx 47 with a new profile.   When looking at the network tab of Browser Toolbox, I noticed a difference in the cookie in the first GET request.

Not-working profile sends these parameters in cookie, and there is no response.
guest_id
_twitter_sess
_ga
kdt
remember_checked_on
twid
auth_token
lang

Working profile only sends 2 parameters, and Fx receives a response then sends a next GET request.
guest_id
_twitter_sess
Well, the difference was because I didn't login to Twitter on the new profile.

Further playing with this, a workaround seemed refreshing Fx.  Twitter sharing started working again, then suddenly broke again.  Also Google+ sharing shows the same error "unable to connect".  This doesn't seem an issue on the Twitter/Google+ side.
I found there is the service worker from Twitter in about:serviceworkers.

Scope: https://twitter.com/
Script Spec: https://twitter.com/push_service_worker.js
Current Worker URL: https://twitter.com/push_service_worker.js

I unregistered it (without knowing what it is doing), then Twitter sharing started working.  However the service worker is registered again when I visit twitter.com, then Twitter sharing failes with "unable to connect".

Same for Google+.  If there is the service worker from Google+, sharing fails with "unable to connect".

Scope: https://plus.google.com/
Script Spec: https://plus.google.com/serviceworker.js
Current Worker URL: https://plus.google.com/serviceworker.js
Whiteboard: [platform-rel-Twitter]
platform-rel: --- → ?
Flags: needinfo?(felipc)
platform-rel: ? → ---
(In reply to Irie Shin from comment #19)
> I found there is the service worker from Twitter in about:serviceworkers.
> 
> Scope: https://twitter.com/
> Script Spec: https://twitter.com/push_service_worker.js
> Current Worker URL: https://twitter.com/push_service_worker.js
> 
> I unregistered it (without knowing what it is doing), then Twitter sharing
> started working.  However the service worker is registered again when I
> visit twitter.com, then Twitter sharing failes with "unable to connect".
> 
> Same for Google+.  If there is the service worker from Google+, sharing
> fails with "unable to connect".
> 
> Scope: https://plus.google.com/
> Script Spec: https://plus.google.com/serviceworker.js
> Current Worker URL: https://plus.google.com/serviceworker.js

Nice!  Are you still able to reproduce this on any current version?
Flags: needinfo?(irie-sin)
I still get "Firefox is unable to connect with Twitter right now" every single time, on FF 47.0.1, 2 months after I originally reported this...
In 48, I'm unable to reproduce the issue after playing with removing the service workers and getting them re-added (by logging in).  

I suspect there was some issue with service workers in 47, possibly due to the share iframe not being a remote frame (e10s).  If we can get someone to reproduce this under 48 I can try to pursue it further.
(In reply to Shane Caraveo (:mixedpuppy) from comment #23)
> In 48, I'm unable to reproduce the issue after playing with removing the
> service workers and getting them re-added (by logging in).  
> 
> I suspect there was some issue with service workers in 47, possibly due to
> the share iframe not being a remote frame (e10s).  If we can get someone to
> reproduce this under 48 I can try to pursue it further.

I've upgraded to 48.0 and can no longer reproduce this bug.  The Twitter share functionality is now operating as expected again.
(In reply to Shane Caraveo (:mixedpuppy) from comment #20)
> 
> Nice!  Are you still able to reproduce this on any current version?


Unfortunately (or fortunately) the issue no longer occurs after I upgraded to Fx 48.0 earlier this week.  The profile is the same one I used for Fx 47.x.  It seems the isuse was fixed by some changes between 47.x and 48.0.
I tried to reproduce this issue using Firefox 47.0b9, 46.0b10 and 51.0 (2017.01.18) on Mac OS X 10.11 and Win 8.1 x64, it is no longer reproducible.
Based on previous comments I am closing this issue as works for me.
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: qawanted
Resolution: --- → WORKSFORME
Flags: needinfo?(irie-sin)
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: