Closed Bug 1277948 Opened 8 years ago Closed 8 years ago

Redirect the donation link in aboutDialog to https://donate.mozilla.org/thunderbird/about/

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird50 fixed, thunderbird_esr4547+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 50.0
Tracking Flags:
Tracking Status
thunderbird47 --- wontfix
thunderbird48 --- fixed
thunderbird49 --- fixed
thunderbird50 --- fixed
thunderbird_esr45 47+ fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file)

bug1277948_donate_url.v2.patch
2.42 KB, patch
rkent
: review+
jorgk-bmo
: approval-comm-aurora+
jorgk-bmo
: approval-comm-beta+
rkent
: approval-comm-esr45+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1272972 +++

As discussed in bug 1272972, we want the donation link to show you content in your own language.

Instead of https://donate.mozilla.org/en-US/thunderbird/about/ we should use https://donate.mozilla.org/thunderbird/about/ once https://github.com/mozilla/donate.mozilla.org/pull/1576 is in production.
I'll hold off asking for review until the PR is in production.
Comment on attachment 8759826 [details] [diff] [review]
bug1277948_donate_url.v2.patch

Review of attachment 8759826 [details] [diff] [review]:
-----------------------------------------------------------------

https://donate.mozilla.org/thunderbird/about/ is redirecting properly now
Attachment #8759826 - Flags: review?(rkent)
Comment on attachment 8759826 [details] [diff] [review]
bug1277948_donate_url.v2.patch

Review of attachment 8759826 [details] [diff] [review]:
-----------------------------------------------------------------

Yes looks good, compiled and ran and it worked fine.
Attachment #8759826 - Flags: review?(rkent) → review+
https://hg.mozilla.org/comm-central/rev/4f9fcae55b38 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
Comment on attachment 8759826 [details] [diff] [review]
bug1277948_donate_url.v2.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Always go to en-US donate page instead of localized

We should fix this on esr, don't know if we care on the branches
Attachment #8759826 - Flags: approval-comm-esr45?
Attachment #8759826 - Flags: approval-comm-beta?
Attachment #8759826 - Flags: approval-comm-aurora?
Comment on attachment 8759826 [details] [diff] [review]
bug1277948_donate_url.v2.patch

I care about the branches. The uplift train runs every weekend ;-)
Attachment #8759826 - Flags: approval-comm-beta?
Attachment #8759826 - Flags: approval-comm-beta+
Attachment #8759826 - Flags: approval-comm-aurora?
Attachment #8759826 - Flags: approval-comm-aurora+
Comment on attachment 8759826 [details] [diff] [review]
bug1277948_donate_url.v2.patch

Although this did not make beta 47, it is easy to test manually, and the impact on failure is less than the impact on success. So let's take it for esr45.2
Attachment #8759826 - Flags: approval-comm-esr45? → approval-comm-esr45+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: