Closed Bug 1277979 Opened 3 years ago Closed 3 years ago

Fix OSX 10.10 GTests on Gecko 49+

Categories

(Core :: ImageLib, defect)

Product:
Core
Component:
ImageLib
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 + fixed
firefox50 + fixed

People

(Reporter: RyanVM, Assigned: seth)

References

Details

Attachments

(1 file)

Add more fuzz to the downscale-during-decode GTests to fix failures on OS 10.10.
1.61 KB, patch
Details | Diff | Splinter Review 
OSX 10.10 GTests were recently enabled across the board. Turns out they're permafailing on trunk (but nowhere else).

Seth, looks like the failing tests are ones you added recently. Can you please take a look?
https://treeherder.mozilla.org/logviewer.html#?job_id=29440562&repo=mozilla-inbound
Flags: needinfo?(seth)
(In reply to Ryan VanderMeulen [:RyanVM] (Away June 4-20) from comment #0)
> OSX 10.10 GTests were recently enabled across the board. Turns out they're
> permafailing on trunk (but nowhere else).
> 
> Seth, looks like the failing tests are ones you added recently. Can you
> please take a look?
> https://treeherder.mozilla.org/logviewer.html#?job_id=29440562&repo=mozilla-
> inbound

Looks to me like they just need a bit of fuzz. The patch is trivial; I think it'd be reasonable to r=me it.
Just a fuzz bump; not bothering with review for this.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a641275e97e48f383f1ed65363109e94c475b9b
Bug 1277979 - Add more fuzz to the downscale-during-decode GTests to fix failures on OS 10.10. r=me
Flags: needinfo?(seth)
Assignee: nobody → seth
[Tracking Requested - why for this release]: No OSX GTest coverage on 49+
status-firefox50: --- → affected
tracking-firefox49: --- → ?
tracking-firefox50: --- → ?
Summary: Fix OSX 10.10 GTests on Gecko 49 → Fix OSX 10.10 GTests on Gecko 49+
Pushed by mfowler@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b088b6f8312
Add even more fuzz to the downscale-during-decode GTests to fix failures on OS 10.10. r=me DONTBUILD
Let's see if that will do it.
Flags: needinfo?(seth)
Yeah, that took care of it!
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox50: affected → fixed
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [checkin-needed-aurora]
Target Milestone: --- → mozilla50
Tracking 49+ to ensure test coverage on 49+
tracking-firefox49: ? → +
Pushed by mfowler@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee398bddc25a
(Followup) - Unfortunately still more fuzz is needed for downscale-during-decode GTests on OS X 10.10. r=me
(In reply to Marcia Knous [:marcia - use ni] from comment #12)
> Tracking 49+ to ensure test coverage on 49+

And for 50 as well.
tracking-firefox50: ? → +
You need to log in before you can comment on or make changes to this bug.