1277983 - Improve existing bookmarks tracker tests

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Lina Butler [:lina]]

Splitting this out of bug 1258127 so that it can help us make changes to the tracker (bug 1274496, for example).

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1277983 - Improve bookmarks engine test logging and remove a deprecated call.

Review commit: https://reviewboard.mozilla.org/r/57710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57710/

Comment 2

[Lina Butler [:lina]]

Attachment: Bug 1277983 - Improve existing bookmarks tracker tests.

The intention of this patch is 2-fold:

* Capture more existing semantics of the tracker that aren't currently tested.
  The intention is that this patch doesn't touch the existing tracker or
  bookmarks engine implementation at all.

* Make structural changes such that later patches that want to ensure the
  same semantics exist using SQL queries are more obvious and limited
  only to things directly related to the new tracker - for example, this patch
  uses tasks/promises even though they aren't necessary here, but will become
  necessary in later patches.

Review commit: https://reviewboard.mozilla.org/r/57712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57712/

Comment 3

[Lina Butler [:lina]]

Comment on attachment 8759877 [details]
Bug 1277983 - Improve bookmarks engine test logging and remove a deprecated call.

Carrying over r+ from bug 1258127, comment 44.

Comment 4

[Lina Butler [:lina]]

Comment on attachment 8759878 [details]
Bug 1277983 - Improve existing bookmarks tracker tests.

Carrying over r+ from bug 1258127, comment 54.

Comment 5

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b2736e244ed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/219c434c410e
Improve bookmarks engine test logging and remove a deprecated call. r=kitcambridge
https://hg.mozilla.org/integration/fx-team/rev/9e2fcb41e05a
Improve existing bookmarks tracker tests. r=markh

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/219c434c410e
https://hg.mozilla.org/mozilla-central/rev/9e2fcb41e05a