1277999 - Regression: History smartfolder icons are too big

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

For some reason, the icons for smartfolders have embiggened themselves. I checked the dimensions used (favicon_bg) but it doesn't seem to have changed, so something else is going on.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Bug 1277999 - Regression: History smartfolder icons are too big.

Review commit: https://reviewboard.mozilla.org/r/58372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58372/

Comment 2

[Chenxia Liu [:liuche]]

This icon doesn't need to be scaled or centered - it was just missing some padding in order to match the dimens in the mocks.

Comment 3

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 8760997 [details]
Bug 1277999 - Regression: History smartfolder icons are too big.

https://reviewboard.mozilla.org/r/58372/#review55230

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6b9019f91562
Regression: History smartfolder icons are too big. r=jonalmeida

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b9019f91562

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8760997 [details]
Bug 1277999 - Regression: History smartfolder icons are too big.

Approval Request Comment
[Feature/regressing bug #]: bug 1261527 scaled icon
[User impact if declined]: smartfolder icon for Synced devices will be too big
[Describe test coverage new/current, TreeHerder]: local testing
[Risks and why]: very low, adds padding, removes scaling in xml
[String/UUID change made/needed]: none

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8760997 [details]
Bug 1277999 - Regression: History smartfolder icons are too big.

It looks like this changes how icons are displayed on hdpi devices, so let's not uplift this patch.

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed in build 50.0a1 (2016-06-16);
Device: 
- Asus ZenPad 8 (Android 5.0.2);
- Motorola Razr (Android 4.4.4);
- Nexus 5 (Android 6.0.1).