1278 - box properties on inline elements should not increase line height

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

padding, border, and margin on non-replaced inline elements should not increase
line height.  They should be drawn in, but they should only change the spacing
on the sides of the elements.

See the spec:
http://www.w3.org/TR/REC-CSS1#the-height-of-lines
http://www.w3.org/TR/REC-CSS2/visudet.html#q22

New tests in the CSS1 test suite on this topic are forthcoming.  Stay tuned.

Comment 1

[leger]

Setting all current Open/Normal to M4.

Comment 2

[kipp]

The box properties margin, padding and border no longer increase the line-height
for inline non-replaced elements.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

You're still not doing it right for the top of the first line and the bottom of
the last.  The blue should actually go outside the body in the above URL.  The
problem also shows up in the above URL and in the gray DIVs in

http://www.w3.org/Style/CSS/Test/current/sec548.htm

where you don't have any spacing from the line-height at the edges of the DIVs.

I'm verifying bug 585 (from which the above came from) and reopening this one.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

You're right - the inline.html is fine.  However, section 548 is not, I think.
The problem is shown more clearly on:

http://www.fas.harvard.edu/~dbaron/csstest/linebox4

Comment 5

[Paul MacQuiddy]

per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Comment 6

[kipp]

Fixed. Every test I could find now passes, include all the tests mentioned in
this page and in bug #1990.

Comment 7

[Hixie (not reading bugmail)]

After brief discussion David and I agree that this bug is fixed.
Verified with 1999-03-23 Win32 build.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I agree that sec548 is fine.  The linebox4 issues are now part of bug 4234.

Leaving bug verified.