Closed
Bug 1278004
Opened 6 years ago
Closed 6 years ago
support QIing proxied accessibles to nsIAccessibleValue
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(1 file)
5.20 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8759896 -
Flags: review?(dbolter)
Comment 2•6 years ago
|
||
Comment on attachment 8759896 [details] [diff] [review] support QIing proxied accessibles to nsIAccessibleValue Review of attachment 8759896 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/ipc/ProxyAccessible.h @@ +438,2 @@ > const bool mIsDoc: 1; > + const bool mHasValue: 1; optional: I'd be tempted to call it mHasValueInterface ::: accessible/xpcom/xpcAccessibleDocument.cpp @@ +217,5 @@ > + if (aProxy->mHasValue) { > + interfaces |= eValue; > + } > + > + acc = new xpcAccessibleGeneric(aProxy, interfaces); Will there eventually be something like: acc = new xpcAccessibleGeneric(aProxy, aProxy->GetInterfaces()); (obviously the constructor could just grab the interfaces)
Attachment #8759896 -
Flags: review?(dbolter) → review+
Pushed by tsaunders@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ffa4bbcb60b support QIing proxied accessibles to nsIAccessibleValue r=davidb
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ffa4bbcb60b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•6 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•