1278004 - support QIing proxied accessibles to nsIAccessibleValue

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: support QIing proxied accessibles to nsIAccessibleValue

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8759896 [details] [diff] [review]
support QIing proxied accessibles to nsIAccessibleValue

Review of attachment 8759896 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/ipc/ProxyAccessible.h
@@ +438,2 @@
>    const bool mIsDoc: 1;
> +  const bool mHasValue: 1;

optional: I'd be tempted to call it mHasValueInterface

::: accessible/xpcom/xpcAccessibleDocument.cpp
@@ +217,5 @@
> +  if (aProxy->mHasValue) {
> +    interfaces |= eValue;
> +  }
> +
> +  acc = new xpcAccessibleGeneric(aProxy, interfaces);

Will there eventually be something like:
acc = new xpcAccessibleGeneric(aProxy, aProxy->GetInterfaces());
(obviously the constructor could just grab the interfaces)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ffa4bbcb60b
support QIing proxied accessibles to nsIAccessibleValue r=davidb

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ffa4bbcb60b