All users were logged out of Bugzilla on October 13th, 2018

support QIing proxied accessibles to nsIAccessibleValue

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8759896 [details] [diff] [review]
support QIing proxied accessibles to nsIAccessibleValue
Attachment #8759896 - Flags: review?(dbolter)
Comment on attachment 8759896 [details] [diff] [review]
support QIing proxied accessibles to nsIAccessibleValue

Review of attachment 8759896 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/ipc/ProxyAccessible.h
@@ +438,2 @@
>    const bool mIsDoc: 1;
> +  const bool mHasValue: 1;

optional: I'd be tempted to call it mHasValueInterface

::: accessible/xpcom/xpcAccessibleDocument.cpp
@@ +217,5 @@
> +  if (aProxy->mHasValue) {
> +    interfaces |= eValue;
> +  }
> +
> +  acc = new xpcAccessibleGeneric(aProxy, interfaces);

Will there eventually be something like:
acc = new xpcAccessibleGeneric(aProxy, aProxy->GetInterfaces());
(obviously the constructor could just grab the interfaces)
Attachment #8759896 - Flags: review?(dbolter) → review+

Comment 3

2 years ago
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ffa4bbcb60b
support QIing proxied accessibles to nsIAccessibleValue r=davidb

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ffa4bbcb60b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

Updated

2 years ago
Blocks: 1276721

Updated

2 years ago
No longer blocks: 1276721
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.