Closed
Bug 1278006
Opened 10 years ago
Closed 10 years ago
MenuViewController is not being released correctly causing memory leaks
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios-v5.0 | --- | fixed |
People
(Reporter: farhan, Assigned: farhan)
Details
Attachments
(3 files)
theLeak.png
The MenuViewController isn't being released and is causing a small memory leak (About 0.5MB - 1MB) every time it is opened and closed.
The menu's delegates menuItemDataSource/Delegate are held as strong references which are never released.
You can replicate this by adding the deinit method to the MenuViewController and creating a breakpoint (It is never triggered)
I've also added an attachment of the memory leak in instruments
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Have a look Emily! It's a small leak but the first one I found.
It's actually real fun digging through instruments and finding leaks like this.
Attachment #8759903 -
Flags: review?(etoop)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8759903 [details] [review]
Pull Request
nice catch
Attachment #8759903 -
Flags: review?(etoop) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
master 4242d2a1c99ca4c87e9bdaf388b1224abc5c8491
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
|
|
||
Comment 5•10 years ago
|
||
v5.x eea5117f1fbff2119bd6479cb5a97e24ea5b185f
status-fxios-v5.0:
--- → fixed
Whiteboard: [needsuplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•