Closed Bug 1278007 Opened 3 years ago Closed 3 years ago

Assertion failure: !(state & (ItemState::eFirstBaseline | ItemState::eLastBaseline)) == !(state & (ItemState::eSelfBaseline | ItemState::eContentBaseline)) (first/last bit requires self/content bit and vice versa)

Categories

(Core :: Layout, defect, P1)

49 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files)

Attached file testcase
No description provided.
Attached patch fix+crashtestSplinter Review
Attachment #8759906 - Flags: review?(dholbert)
Attachment #8759906 - Flags: review?(dholbert) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ee67012a982
[css-grid] Reset all baseline bits when we decide a grid item doesn't participate in [first|last]-baseline alignment.  r=dholbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8ee67012a982
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: 1277767
Mats can you request uplift for 49?
Flags: needinfo?(mats)
Comment on attachment 8759906 [details] [diff] [review]
fix+crashtest

Approval Request Comment
[Feature/regressing bug #]: bug 1221525
[User impact if declined]: fatal assertion in DEBUG builds, likely nothing bad in Opt builds.
[Describe test coverage new/current, TreeHerder]: patch includes tests
[Risks and why]: zero risk, trivial fix
[String/UUID change made/needed]: none
Flags: needinfo?(mats)
Attachment #8759906 - Flags: approval-mozilla-aurora?
Comment on attachment 8759906 [details] [diff] [review]
fix+crashtest

Regression in debug builds (49) Let's uplift this test fix.
Attachment #8759906 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.